Skip to content

Conversation

@RCGV1
Copy link
Member

@RCGV1 RCGV1 commented Nov 26, 2025

What changed?

We now create the initial value for index i var outside the for loop so multiple cchannels dont try to overwrite each other. Also we call channel packet function to update the UI with new channels.

Why did it change?

Before adding multiple cahnnels via QR would only add one and this would not be reflected in the UI.

How is this tested?

Tested sending multiple qr codes from android to iOS

Screenshots/Videos (when applicable)

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have verified whether these changes require an update to existing documentation or if new documentation is needed, and created an issue in the docs repo if applicable.
  • I have tested the change to ensure that it works as intended.

@thebentern thebentern requested a review from Copilot November 27, 2025 00:28
Copilot finished reviewing on behalf of thebentern November 27, 2025 01:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where adding multiple channels via QR code would only add one channel and not reflect the changes in the UI. The fix involves initializing the channel index counter outside the for loop and calling the channelPacket function to update the UI for each added channel.

Key Changes

  • Moved index variable initialization outside the for loop to prevent channels from overwriting each other
  • Added channelPacket function call to update the UI with newly added channels

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant