Skip to content

Conversation

@compumike
Copy link

@compumike compumike commented Nov 1, 2025

(Marking this PR as draft while the upstream cross-platform feature request meshtastic/firmware#8514 is discussed. This PR should just be for discussion of the iOS/macOS specific implementation.)

For people who connect the app directly to a CLIENT_BASE node, add two warnings:

  1. warning when they click "Add to favorites"
  2. warning when they switch the role to CLIENT_BASE

This should help with people accidentally adding favorites from a CLIENT_BASE. Similar to the existing messages about ROUTER.


How is this tested?

Tested on iOS and macOS.


Screenshots/Videos (when applicable)

Clicking "Add to favorites" on a node:

Screenshot 2025-11-01 at 5 14 23 PM IMG_1650

In device configuration, changing role to "Client Base":

Screenshot 2025-11-03 at 4 45 39 PM IMG_1676

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have verified whether these changes require an update to existing documentation or if new documentation is needed, and created an issue in the docs repo if applicable.
  • I have tested the change to ensure that it works as intended.

@garthvh
Copy link
Member

garthvh commented Nov 1, 2025

Has this actually been an issue?

@compumike
Copy link
Author

@garthvh not that I've personally experienced, but some people are reporting it happening to them on this discussion: meshtastic/firmware#8367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants