CLIENT_BASE add-favorite/role-change confirmation dialog
#1493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Marking this PR as draft while the upstream cross-platform feature request meshtastic/firmware#8514 is discussed. This PR should just be for discussion of the iOS/macOS specific implementation.)
For people who connect the app directly to a
CLIENT_BASEnode, add two warnings:CLIENT_BASEThis should help with people accidentally adding favorites from a
CLIENT_BASE. Similar to the existing messages aboutROUTER.How is this tested?
Tested on iOS and macOS.
Screenshots/Videos (when applicable)
Clicking "Add to favorites" on a node:
In device configuration, changing role to "Client Base":
Checklist