Skip to content

Conversation

@mdecourcy
Copy link
Collaborator

@mdecourcy mdecourcy commented Nov 22, 2025

MapLibre has near feature parity with Google Maps and actually has some advantages:

MapLibre Exclusive Features:

  1. Heatmap mode - Density visualization
  2. Role legend - Shows node role colors
  3. Offline tile caching - Ambient cache management
  4. Clustering toggle - Can be disabled
  5. Clustering actions - radial overlay of nodes for cluster of size <= 8
  6. Role-based filtering - Filter by device roles

Google Maps Exclusive Features

  1. Richer info windows - Full NodeChip display with details
  2. Track point info windows - Position details on track points

Things that I'm shelving for later (in no particular order):

  1. heatmap will need some touch up
  2. Reposition node type legend
  3. Consider moving location button above zoom in/out buttons
  4. Gut osmdroid
  5. Gut gmaps after successful fdroid userbase testing
  6. raster maps
  7. unsure if precision bits are working as intended. Doesn't smell right
  8. Node trackpoints enhancements to get parity w/ gmaps
  9. Lifecycle management improvements
  10. Better label hiding logic

Will address the missing features in separate PRs. This PR is already way too big, sorry guys

image image image image image image image image

mdecourcy and others added 30 commits November 14, 2025 08:49
…tastic#3704)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: b8b8 <[email protected]>
Co-authored-by: James Rich <[email protected]>
meshtastic#3718)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mdecourcy mdecourcy changed the title feat: maplibre WIP: feat: maplibre Nov 22, 2025
@jamesarich jamesarich requested a review from Copilot November 22, 2025 17:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot finished reviewing on behalf of jamesarich November 22, 2025 18:09
@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

❌ Patch coverage is 0% with 2219 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.51%. Comparing base (f9575a2) to head (7231f7d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../meshtastic/feature/map/maplibre/ui/MapLibrePOC.kt 0.00% 745 Missing ⚠️
.../feature/map/maplibre/core/MapLibreLayerManager.kt 0.00% 296 Missing ⚠️
...g/meshtastic/feature/map/maplibre/ui/MapLibreUI.kt 0.00% 194 Missing ⚠️
...c/feature/map/maplibre/utils/MapLibreLayerUtils.kt 0.00% 175 Missing ⚠️
...ture/map/maplibre/core/MapLibreDataTransformers.kt 0.00% 116 Missing ⚠️
...stic/feature/map/maplibre/utils/MapLibreHelpers.kt 0.00% 108 Missing ⚠️
.../feature/map/maplibre/core/MapLibreStyleBuilder.kt 0.00% 106 Missing ⚠️
.../feature/map/maplibre/ui/MapLibreControlButtons.kt 0.00% 104 Missing ⚠️
...tastic/feature/map/maplibre/ui/MapClickHandlers.kt 0.00% 85 Missing ⚠️
...tastic/feature/map/maplibre/ui/MapLibreOverlays.kt 0.00% 82 Missing ⚠️
... and 8 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3785      +/-   ##
========================================
- Coverage   0.56%   0.51%   -0.06%     
========================================
  Files        381     398      +17     
  Lines      21733   23919    +2186     
  Branches    2684    3069     +385     
========================================
  Hits         122     122              
- Misses     21591   23777    +2186     
  Partials      20      20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.

@jamesarich jamesarich added this to the 2.7.9 milestone Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants