Undefined variable php warning

[daphilli224]

I'm receiving an undefined variable $template_dir_select when adding a product to an order with edit orders. The warning is: PHP Warning: Undefined variable $template_dir_select in /admin/includes/init_includes/init_eo_sba.php on line 314. Same warning occurs for line 315 in the same file.

I fixed the problem by changing line 314 to: if (!empty($template_dir_select) && file_exists(DIR_WS_LANGUAGES . $_SESSION['language'] . '/' . $template_dir_select . 'edit_orders_sba.php')) {

My apologies if this has been reported before.

Dave
zc157c, php 8.0.22

[mc12345678]

What version of edit orders?

Still looking into how this issue could occur in a default install of zencart 1.5.7 based on how the three pieces of software used to work, but in zencart 1.5.8, this appears as it would definitely become an issue as generally speaking the previously globally available variable $template_dir_select just basically does not exist any more and yet still is referenced in some of the zencart core software.

The solution provided will eliminate the debug report, but doesn't really resolve the issue of being able to use a template based version of the file. Unfortunately, though either need to internally determine the expected value or check for the existence of a tool that makes that action happen.

Note a similar issue may occur when trying to copy a product that has attributes (haven't looked back to determine if matters whether the attributes are tracked by sba or not). I know it will happen in 1.5.8.

[newnaturals]

Hi Cindy, I’m away from the office for a couple of days on a business trip. I’ll get on this as soon as I’m back. I assume we have the most recent version of Edit Orders, as it was a fresh install when I upgraded to 1.5.7d last year. I will check that in the morning. HeleneOn Jun 25, 2023, at 12:32 PM, mc12345678 ***@***.***> wrote: What version of edit orders? Still looking into how this issue could occur in a default install of zencart 1.5.7 based on how the three pieces of software used to work, but in zencart 1.5.8, this appears as it would definitely become an issue as generally speaking the previously globally available variable $template_dir_select just basically does not exist any more and yet still is referenced in some of the zencart core software. The solution provided will eliminate the debug report, but doesn't really resolve the issue of being able to use a template based version of the file. Unfortunately, though either need to internally determine the expected value or check for the existence of a tool that makes that action happen. Note a similar issue may occur when trying to copy a product that has attributes (haven't looked back to determine if matters whether the attributes are tracked by sba or not). I know it will happen in 1.5.8. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[newnaturals]

Oops, my apologies, not Cindy and I didn’t realize that I wasn’t replying to a private email. Sorry about that. On Jun 25, 2023, at 7:10 PM, Helene ***@***.***> wrote:Hi Cindy, I’m away from the office for a couple of days on a business trip. I’ll get on this as soon as I’m back. I assume we have the most recent version of Edit Orders, as it was a fresh install when I upgraded to 1.5.7d last year. I will check that in the morning. HeleneOn Jun 25, 2023, at 12:32 PM, mc12345678 ***@***.***> wrote: What version of edit orders? Still looking into how this issue could occur in a default install of zencart 1.5.7 based on how the three pieces of software used to work, but in zencart 1.5.8, this appears as it would definitely become an issue as generally speaking the previously globally available variable $template_dir_select just basically does not exist any more and yet still is referenced in some of the zencart core software. The solution provided will eliminate the debug report, but doesn't really resolve the issue of being able to use a template based version of the file. Unfortunately, though either need to internally determine the expected value or check for the existence of a tool that makes that action happen. Note a similar issue may occur when trying to copy a product that has attributes (haven't looked back to determine if matters whether the attributes are tracked by sba or not). I know it will happen in 1.5.8. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[daphilli224]

Hi mc, I’m using edit orders 4.6.2. sba is version 1.5.4, files dated 3/22/2021. I’ve checked the latest version of admin/includes/init_includes/init_eo_sba.php on github and found the code in the area of the warnings is unchanged from my version. I admit my solution is a band aid, but I also know I don’t have a template specific version of the file. I also admit I don’t know what $template_dir_select is and how it differs from $template_dir. If I can be of further assistance in your efforts to find the cause/solution, please let me know. I am not ready however to migrate to zc1.5.8 yet. Thank you for your efforts to maintain sba and for your assistance to me and others on all kinds of questions/problems/issues. Dave

…

On Jun 25, 2023, at 12:32 PM, mc12345678 ***@***.***> wrote: What version of edit orders? Still looking into how this issue could occur in a default install of zencart 1.5.7 based on how the three pieces of software used to work, but in zencart 1.5.8, this appears as it would definitely become an issue as generally speaking the previously globally available variable $template_dir_select just basically does not exist any more and yet still is referenced in some of the zencart core software. The solution provided will eliminate the debug report, but doesn't really resolve the issue of being able to use a template based version of the file. Unfortunately, though either need to internally determine the expected value or check for the existence of a tool that makes that action happen. Note a similar issue may occur when trying to copy a product that has attributes (haven't looked back to determine if matters whether the attributes are tracked by sba or not). I know it will happen in 1.5.8. — Reply to this email directly, view it on GitHub <#109 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVXNN2FPFKXUJWTZ47KY64DXNBRZ7ANCNFSM6AAAAAAZTGGY6I>. You are receiving this because you authored the thread.