Skip to content

Commit 186357e

Browse files
sgiehllachiebol
andcommitted
Update API documentation for Goals (#24363)
* Updated API documentation for Goals plugin * Keep existing class level docs * Fixed idSite inconsistency * Update API documentation for Goals * apply further improvements --------- Co-authored-by: Lachlan Reynolds <lachlan.reynolds@innocraft.com>
1 parent e410bc3 commit 186357e

6 files changed

Lines changed: 368 additions & 138 deletions

File tree

core/Site.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class Site
5353
];
5454

5555
/**
56-
* @var int|null
56+
* @var int
5757
*/
5858
protected $id = null;
5959

phpstan-baseline.neon

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3328,11 +3328,6 @@ parameters:
33283328
count: 1
33293329
path: plugins/Goals/API.php
33303330

3331-
-
3332-
message: "#^Parameter \\#6 \\$columns of method Piwik\\\\Plugins\\\\Goals\\\\API\\:\\:get\\(\\) expects array, string given\\.$#"
3333-
count: 1
3334-
path: plugins/Goals/API.php
3335-
33363331
-
33373332
message: "#^Variable \\$table in isset\\(\\) always exists and is not nullable\\.$#"
33383333
count: 1
@@ -3398,11 +3393,6 @@ parameters:
33983393
count: 1
33993394
path: plugins/Goals/Pages.php
34003395

3401-
-
3402-
message: "#^Parameter \\#1 \\$idSite of method Piwik\\\\Plugins\\\\Goals\\\\API\\:\\:getGoals\\(\\) expects array\\|string, int\\|null given\\.$#"
3403-
count: 1
3404-
path: plugins/Goals/RecordBuilders/GeneralGoalsRecords.php
3405-
34063396
-
34073397
message: "#^Strict comparison using \\=\\=\\= between array\\|Zend_Db_Statement and false will always evaluate to false\\.$#"
34083398
count: 1

0 commit comments

Comments
 (0)