_ prefix unused variables

bump ruff from 0.1.7 to 0.1.8

Author: janosh

.pre-commit-config.yaml

@@ -8,7 +8,7 @@ ci:
 
 repos:
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.1.7
+    rev: v0.1.8
     hooks:
       - id: ruff
         args: [--fix]
@@ -47,7 +47,7 @@ repos:
       - id: blacken-docs
 
   - repo: https://github.com/igorshubovych/markdownlint-cli
-    rev: v0.37.0
+    rev: v0.38.0
     hooks:
       - id: markdownlint
         # MD013: line too long

pymatgen/analysis/adsorption.py

@@ -601,7 +601,7 @@ def get_mi_vec(slab):
 def get_rot(slab):
     """Gets the transformation to rotate the z axis into the miller index."""
     new_z = get_mi_vec(slab)
-    a, b, c = slab.lattice.matrix
+    a, _b, _c = slab.lattice.matrix
     new_x = a / np.linalg.norm(a)
     new_y = np.cross(new_z, new_x)
     x, y, z = np.eye(3)

pymatgen/analysis/chemenv/connectivity/connected_components.py

@@ -33,7 +33,7 @@ def draw_network(env_graph, pos, ax, sg=None, periodicity_vectors=None):
         c = Circle(pos[n], radius=0.02, alpha=0.5)
         ax.add_patch(c)
         env_graph.node[n]["patch"] = c
-        x, y = pos[n]
+        _x, _y = pos[n]
         ax.annotate(str(n), pos[n], ha="center", va="center", xycoords="data")
     seen = {}
     e = None

pymatgen/analysis/chemenv/coordination_environments/chemenv_strategies.py

@@ -596,7 +596,7 @@ def get_site_neighbors(self, site, isite=None, dequivsite=None, dthissite=None,
         if isite is None:
             isite, dequivsite, dthissite, mysym = self.equivalent_site_index_and_transform(site)
 
-        ce, cn_map = self.get_site_coordination_environment(
+        _ce, cn_map = self.get_site_coordination_environment(
             site=site,
             isite=isite,
             dequivsite=dequivsite,

pymatgen/analysis/chemenv/coordination_environments/coordination_geometry_finder.py

@@ -313,7 +313,7 @@ def find_rotation(points_distorted, points_perfect):
         The rotation matrix.
     """
     H = np.matmul(points_distorted.T, points_perfect)
-    U, S, Vt = svd(H)
+    U, _S, Vt = svd(H)
     return np.matmul(Vt.T, U.T)
 
 

pymatgen/analysis/chemenv/coordination_environments/voronoi.py

@@ -495,7 +495,7 @@ def neighbors_surfaces_bounded(self, isite, surface_calculation_options=None):
                     ap2 = angle_bounds[iap]
                 if ap2 < minang or ap1 > maxang:
                     continue
-                intersection, interror = rectangle_surface_intersection(
+                intersection, _interror = rectangle_surface_intersection(
                     rectangle=((d1, d2), (ap1, ap2)),
                     f_lower=f_lower,
                     f_upper=f_upper,

pymatgen/analysis/chemenv/utils/coordination_geometry_utils.py

@@ -1037,7 +1037,7 @@ def from_npoints_least_square_distance(cls, points):
         for ii, pp in enumerate(points):
             for jj in range(3):
                 AA[ii, jj] = pp[jj] - mean_point[jj]
-        [UU, SS, Vt] = np.linalg.svd(AA)
+        _UU, SS, Vt = np.linalg.svd(AA)
         imin = np.argmin(SS)
         normal_vector = Vt[imin]
         non_zeros = np.argwhere(normal_vector != 0.0)

pymatgen/analysis/chemenv/utils/graph_utils.py

@@ -225,7 +225,7 @@ def order(self, raise_on_fail=True):
             self.ordered = False
             return
 
-        min_index, min_node = min(enumerate(self.nodes), key=operator.itemgetter(1))
+        min_index, _min_node = min(enumerate(self.nodes), key=operator.itemgetter(1))
         reverse = self.nodes[(min_index - 1) % len(self.nodes)] < self.nodes[(min_index + 1) % len(self.nodes)]
         if reverse:
             self.nodes = self.nodes[min_index::-1] + self.nodes[:min_index:-1]
@@ -413,7 +413,7 @@ def order(self, raise_on_fail=True):
             self.ordered = False
             return
 
-        min_index, min_node = min(enumerate(self.nodes), key=operator.itemgetter(1))
+        min_index, _min_node = min(enumerate(self.nodes), key=operator.itemgetter(1))
 
         # Special case when number of nodes is 2 because the two
         # edge_indices refer to the same pair of nodes

pymatgen/analysis/chempot_diagram.py

@@ -466,7 +466,7 @@ def _get_3d_domain_simplexes_and_ann_loc(
         into 2-dimensional space so that ConvexHull can be used to identify the
         bounding polygon.
         """
-        points_2d, v, w = simple_pca(points_3d, k=2)
+        points_2d, _v, w = simple_pca(points_3d, k=2)
         domain = ConvexHull(points_2d)
         centroid_2d = get_centroid_2d(points_2d[domain.vertices])
         ann_loc = centroid_2d @ w.T + np.mean(points_3d.T, axis=1)

pymatgen/analysis/dimensionality.py

@@ -338,11 +338,11 @@ def get_dimensionality_cheon(
         structure = structure_raw
     structure_save = copy.copy(structure_raw)
     connected_list1 = find_connected_atoms(structure, tolerance=tolerance, ldict=ldict)
-    max1, min1, clusters1 = find_clusters(structure, connected_list1)
+    max1, min1, _clusters1 = find_clusters(structure, connected_list1)
     if larger_cell:
         structure.make_supercell([[3, 0, 0], [0, 3, 0], [0, 0, 3]])
         connected_list3 = find_connected_atoms(structure, tolerance=tolerance, ldict=ldict)
-        max3, min3, clusters3 = find_clusters(structure, connected_list3)
+        max3, min3, _clusters3 = find_clusters(structure, connected_list3)
         if min3 == min1:
             dim = "0D" if max3 == max1 else "intercalated molecule"
         else:
@@ -354,7 +354,7 @@ def get_dimensionality_cheon(
     else:
         structure.make_supercell([[2, 0, 0], [0, 2, 0], [0, 0, 2]])
         connected_list2 = find_connected_atoms(structure, tolerance=tolerance, ldict=ldict)
-        max2, min2, clusters2 = find_clusters(structure, connected_list2)
+        max2, min2, _clusters2 = find_clusters(structure, connected_list2)
         if min2 == 1:
             dim = "intercalated ion"
         elif min2 == min1:
@@ -367,7 +367,7 @@ def get_dimensionality_cheon(
                 structure = copy.copy(structure_save)
                 structure.make_supercell([[3, 0, 0], [0, 3, 0], [0, 0, 3]])
                 connected_list3 = find_connected_atoms(structure, tolerance=tolerance, ldict=ldict)
-                max3, min3, clusters3 = find_clusters(structure, connected_list3)
+                max3, min3, _clusters3 = find_clusters(structure, connected_list3)
                 if min3 == min2:
                     dim = "0D" if max3 == max2 else "intercalated molecule"
                 else: