Fix storage permissions. (GoogleCloudPlatform#486)

Author: jmdobry

appengine/storage/system-test/app.test.js

@@ -30,7 +30,7 @@ test.before(async () => {
   await bucket.create(bucket).then((data) => {
     return bucket.acl.add({
       entity: 'allUsers',
-      role: Storage.acl.WRITER_ROLE
+      role: Storage.acl.READER_ROLE
     });
   });
 });

scripts/clean

@@ -23,14 +23,15 @@ if (!args.length || args[0] === 'coverage') {
   rm('-rf', 'coverage');
 } else if (args[0] === 'buckets') {
   const NAME_REG_EXP = /^nodejs-docs-samples-test-[a-z0-9]{8}-[a-z0-9]{4}-[a-z0-9]{4}-[a-z0-9]{4}-[a-z0-9]{12}$/;
+  const NAME_REG_EXP_2 = /^docs-samples-gae-test-[a-z0-9]{8}-[a-z0-9]{4}-[a-z0-9]{4}-[a-z0-9]{4}-[a-z0-9]{12}$/;
 
   storage
     .getBuckets()
     .then(([buckets]) => {
       let promise = Promise.resolve();
 
       buckets
-        .filter((bucket) => NAME_REG_EXP.test(bucket.name))
+        .filter((bucket) => NAME_REG_EXP.test(bucket.name) || NAME_REG_EXP_2.test(bucket.name))
         .forEach((bucket) => {
           promise = promise.then(() => {
             return bucket.deleteFiles()