Apache Superset 4.x support

[donhardman]

Proposal:

Currently, we support Apache Superset 3.x, but version 4.x is now available on the market. We should validate our existing support and implement any missing handlers to fully support the new version.

Checklist:

^{To be completed by the assignee. Check off tasks that have been completed or are not applicable.}

• Implementation completed
• Tests developed
• Documentation updated
• Documentation reviewed
• Changelog updated
• OpenAPI YAML updated and issue created to rebuild clients

[sanikolaev]

As discussed, it's hard to estimate how long it will take to fix it.

[Malgarion]

This problem of Superset connect to Manticore Error 'int' object has no attribute 'upper' (manticoresoftware/manticoresearch#2395) can be fixed by simple modification in sqlalchemy/dialects/mysql/base.py within function

def get_isolation_level(self, connection):
        cursor = connection.cursor()
        if self._is_mysql and self.server_version_info >= (5, 7, 20):
            cursor.execute("SELECT @@transaction_isolation")
        else:
            cursor.execute("SELECT @@tx_isolation")
        row = cursor.fetchone()
        if row is None:
            util.warn(
                "Could not retrieve transaction isolation level for MySQL "
                "connection."
            )
            raise NotImplementedError()
        val = row[0]
        cursor.close()
        if util.py3k and isinstance(val, bytes):
            val = val.decode()
        return val.upper().replace("-", " ")

Problem is that in mysql interface @@tx_isolation and @@transaction_isolation
MySQL [Manticore]> SELECT @@tx_isolation;
+----------------+
| @@tx_isolation |
+----------------+
| 0 |
+----------------+
1 row in set (0.001 sec)

MySQL [Manticore]> SELECT @@transaction_isolation;
+-------------------------+
| @@transaction_isolation |
+-------------------------+
| 0 |
+-------------------------+
return 0 instead of string as specified in mysql documentation, for example
mysql> SELECT @@TX_ISOLATION;
+-----------------+
| @@TX_ISOLATION |
+-----------------+
| REPEATABLE-READ |
+-----------------+
in other word, it is identified as int instead of string is SQLAlchemy.
this can be temporary fix for the issue in the sqlalchemy file:

       if isinstance(val, int):
            val = str(val)  # Convert integer to string

but isolation level has at least be READ UNCOMMITTED. This issue is superset version agnostic, it appeared even in version 3.x

Using version:
Component | Version
Daemon | 7.0.0 92c650401@25013002
Columnar | columnar 4.0.0 5aa8e43@25012409
Secondary | secondary 4.0.0 5aa8e43@25012409
KNN | knn 4.0.0 5aa8e43@25012409
Buddy | buddy v3.17.1+25012911-51758b05

[sanikolaev]

Thanks @Malgarion

We'll try this.

[donhardman]

Before making it work, we should fix the issue on the Manticore daemon side, because when variables do not exist, it always returns 0. Therefore, there is no way to catch it on the Buddy side and process it to fix the issue. @sanikolaev what should we do about it?

mysql> SELECT @@tx_isolation;
+----------------+
| @@tx_isolation |
+----------------+
|              0 |
+----------------+
mysql> SELECT @@tx_isolation_eahhahfefhehfehf;
+---------------------------------+
| @@tx_isolation_eahhahfefhehfehf |
+---------------------------------+
|                               0 |
+---------------------------------+
mysql>

[donhardman]

Blocked by: manticoresoftware/manticoresearch#3109