Skip to content

Commit b86cf57

Browse files
committed
2880: Remove unused Swing imports and simplify dialog classes
Unused Swing-related imports (e.g., JButton, KeyEvent) and redundant code were removed across multiple dialog classes, improving code readability and maintainability. Additionally, some fields were marked as final where applicable and PMD suppressions were updated for better clarity.
1 parent 01a3f3c commit b86cf57

16 files changed

+29
-94
lines changed

check_modified.sh

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
#!/bin/bash
2+
3+
# Get the list of modified files
4+
MODIFIED_FILES=$(git diff --name-only HEAD | grep -E '\.java$' | sed 's/^/"/;s/$/"/' | tr '\n' ',' | sed 's/,$//')
5+
MODIFIED_FILES="[$MODIFIED_FILES]"
6+
7+
# Export the environment variable
8+
export MODIFIED_FILES
9+
10+
# Run the checkstyle and PMD tasks
11+
./gradlew checkstyleCI pmdCI

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/CreateAnObserverDialog.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,13 @@
2424
import com.magento.idea.magento2plugin.magento.packages.File;
2525
import com.magento.idea.magento2plugin.magento.packages.Package;
2626
import com.magento.idea.magento2plugin.ui.FilteredComboBox;
27-
import java.awt.event.KeyEvent;
28-
import java.awt.event.WindowAdapter;
29-
import java.awt.event.WindowEvent;
3027
import java.util.List;
3128
import javax.swing.JButton;
3229
import javax.swing.JComboBox;
3330
import javax.swing.JComponent;
3431
import javax.swing.JLabel;
3532
import javax.swing.JPanel;
3633
import javax.swing.JTextField;
37-
import javax.swing.KeyStroke;
3834
import org.jetbrains.annotations.NotNull;
3935
import org.jetbrains.annotations.Nullable;
4036

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/GatherArrayValuesDialog.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ public class GatherArrayValuesDialog extends AbstractDialog {
4040
private final DiArrayValueData arrayValueData;
4141

4242
private JPanel contentPane;
43-
private JButton buttonCancel;
44-
private JButton buttonOK;
4543
private JPanel itemsPane;// NOPMD
4644
private JScrollPane itemsScrollPane;// NOPMD
4745
private JTable itemsTable;

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/NewCLICommandDialog.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,13 @@
2424
import com.magento.idea.magento2plugin.util.CamelCaseToSnakeCase;
2525
import com.magento.idea.magento2plugin.util.GetPhpClassByFQN;
2626
import com.magento.idea.magento2plugin.util.magento.GetModuleNameByDirectoryUtil;
27-
import java.awt.event.KeyEvent;
28-
import java.awt.event.WindowAdapter;
29-
import java.awt.event.WindowEvent;
3027
import java.util.Locale;
31-
import javax.swing.JButton;
3228
import javax.swing.JComponent;
3329
import javax.swing.JLabel;
3430
import javax.swing.JOptionPane;
3531
import javax.swing.JPanel;
3632
import javax.swing.JTextArea;
3733
import javax.swing.JTextField;
38-
import javax.swing.KeyStroke;
3934
import org.jetbrains.annotations.NotNull;
4035
import org.jetbrains.annotations.Nullable;
4136

@@ -48,8 +43,6 @@ public class NewCLICommandDialog extends AbstractDialog {
4843
private static final String COMMAND_DESCRIPTION = "description";
4944

5045
private JPanel contentPane;
51-
private JButton buttonCancel;
52-
private JButton buttonOK;
5346

5447
@FieldValidation(rule = RuleRegistry.NOT_EMPTY,
5548
message = {NotEmptyRule.MESSAGE, CLASS_NAME})

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/NewCategoryEavAttributeDialog.java

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,20 +47,26 @@
4747
import javax.swing.JTextField;
4848
import org.jetbrains.annotations.Nullable;
4949

50+
/**
51+
* This class handles the creation and configuration of Category EAV attributes.
52+
* Note: This class is flagged as a "God Class" by PMD due to its complexity.
53+
* A proper refactoring into smaller, more focused classes would be a better long-term solution.
54+
*/
5055
@SuppressWarnings({
5156
"PMD.TooManyFields",
5257
"PMD.ExcessiveImports",
5358
"PMD.TooManyMethods",
54-
"PMD.UnusedPrivateField"
59+
"PMD.UnusedPrivateField",
60+
"PMD.GodClass"
5561
})
5662
public class NewCategoryEavAttributeDialog extends AbstractDialog {
5763

5864
private static final String ENTITY_NAME = "Category";
59-
private String moduleName;
60-
private Project project;
61-
private String actionName;
65+
private final String moduleName;
66+
private final Project project;
67+
private final String actionName;
6268
private TableGroupWrapper entityPropertiesTableGroupWrapper;
63-
private SourceModelData sourceModelData;
69+
private final SourceModelData sourceModelData;
6470

6571
private JPanel contentPanel;
6672
private JButton buttonOK;
@@ -171,6 +177,7 @@ protected void initDialogState() {
171177
/**
172178
* Fill attribute type combo box.
173179
*/
180+
@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
174181
protected void fillAttributeTypeComboBox() {
175182
if (typeComboBox == null) {
176183
return;
@@ -186,6 +193,7 @@ protected void fillAttributeTypeComboBox() {
186193
/**
187194
* Fill attribute input combo box.
188195
*/
196+
@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
189197
protected void fillAttributeInputComboBox() {
190198
if (inputComboBox == null) {
191199
return;
@@ -542,12 +550,16 @@ protected void generateExtraFilesBeforeDataPatchGeneration() {
542550

543551
/**
544552
* Generate extra files after data patch generation.
553+
* This is a hook method for subclasses to override and generate additional files.
554+
* The base implementation does nothing.
545555
*
546556
* @param eavEntityDataInterface EavEntityDataInterface
547557
*/
548558
protected void generateExtraFilesAfterDataPatchGeneration(
549559
final EavEntityDataInterface eavEntityDataInterface
550-
) {}
560+
) {
561+
// No additional files to generate in the base implementation
562+
}
551563

552564
/**
553565
* Create center panel.

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/NewControllerDialog.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,14 @@
2323
import com.magento.idea.magento2plugin.magento.packages.Package;
2424
import com.magento.idea.magento2plugin.ui.FilteredComboBox;
2525
import com.magento.idea.magento2plugin.util.magento.GetModuleNameByDirectoryUtil;
26-
import java.awt.event.ActionEvent;
27-
import java.awt.event.KeyEvent;
28-
import java.awt.event.WindowAdapter;
29-
import java.awt.event.WindowEvent;
3026
import java.util.ArrayList;
3127
import java.util.Arrays;
3228
import java.util.List;
33-
import javax.swing.JButton;
3429
import javax.swing.JCheckBox;
3530
import javax.swing.JComponent;
3631
import javax.swing.JLabel;
3732
import javax.swing.JPanel;
3833
import javax.swing.JTextField;
39-
import javax.swing.KeyStroke;
4034
import org.jetbrains.annotations.Nullable;
4135

4236
@SuppressWarnings({
@@ -49,8 +43,6 @@ public class NewControllerDialog extends AbstractDialog {
4943
private final String moduleName;
5044
private final Project project;
5145
private JPanel contentPane;
52-
private JButton buttonOK;
53-
private JButton buttonCancel;
5446
private FilteredComboBox controllerAreaSelect;
5547
private FilteredComboBox httpMethodSelect;
5648
private JCheckBox inheritClass;

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/NewEmailTemplateDialog.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,9 @@
2222
import com.magento.idea.magento2plugin.ui.FilteredComboBox;
2323
import com.magento.idea.magento2plugin.util.magento.GetModuleNameByDirectoryUtil;
2424
import java.awt.event.KeyEvent;
25-
import java.awt.event.WindowAdapter;
26-
import java.awt.event.WindowEvent;
2725
import java.util.ArrayList;
2826
import java.util.Arrays;
2927
import java.util.List;
30-
import javax.swing.JButton;
3128
import javax.swing.JComponent;
3229
import javax.swing.JLabel;
3330
import javax.swing.JPanel;

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/NewEntityDialog.java

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,9 @@
5454
import com.magento.idea.magento2plugin.util.CamelCaseToSnakeCase;
5555
import com.magento.idea.magento2plugin.util.magento.GetAclResourcesListUtil;
5656
import com.magento.idea.magento2plugin.util.magento.GetModuleNameByDirectoryUtil;
57-
import java.awt.Cursor;
5857
import java.awt.event.ActionEvent;
5958
import java.awt.event.KeyAdapter;
6059
import java.awt.event.KeyEvent;
61-
import java.awt.event.WindowAdapter;
62-
import java.awt.event.WindowEvent;
6360
import java.lang.reflect.Field;
6461
import java.util.ArrayList;
6562
import java.util.Arrays;
@@ -358,25 +355,6 @@ private void initPropertiesTable() {
358355
entityPropertiesTableGroupWrapper.initTableGroup();
359356
}
360357

361-
/**
362-
* Generate new entity files.
363-
*
364-
* @param event ActionEvent
365-
*/
366-
@SuppressWarnings("PMD.UnusedFormalParameter")
367-
private void generateNewEntityFiles(final @NotNull ActionEvent event) {
368-
if (!onOkActionFired.isInProgress()) {
369-
if (propertyTable.isEditing()) {
370-
propertyTable.getCellEditor().stopCellEditing();
371-
}
372-
373-
new ProcessWorker(
374-
this::onOK,
375-
this::releaseDialogAfterGeneration,
376-
onOkActionFired
377-
).execute();
378-
}
379-
}
380358

381359
/**
382360
* Perform code generation using input data.
@@ -417,14 +395,6 @@ protected boolean validateFormFields() {
417395
return true;
418396
}
419397

420-
/**
421-
* Release dialog buttons and hide.
422-
*/
423-
private void releaseDialogAfterGeneration() {
424-
if (onOkActionFired.isFinished()) {
425-
exit();
426-
}
427-
}
428398

429399
/**
430400
* Get entity creator context data.

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/NewModuleDialog.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,8 @@
3232
import com.magento.idea.magento2plugin.util.magento.MagentoVersionUtil;
3333
import java.awt.event.ActionEvent;
3434
import java.awt.event.KeyEvent;
35-
import java.awt.event.WindowAdapter;
36-
import java.awt.event.WindowEvent;
3735
import java.util.List;
3836
import java.util.Vector;
39-
import javax.swing.JButton;
4037
import javax.swing.JCheckBox;
4138
import javax.swing.JComponent;
4239
import javax.swing.JLabel;

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/NewObserverDialog.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,22 +34,16 @@
3434
import com.magento.idea.magento2plugin.stubs.indexes.EventNameIndex;
3535
import com.magento.idea.magento2plugin.ui.FilteredComboBox;
3636
import com.magento.idea.magento2plugin.util.CamelCaseToSnakeCase;
37-
import java.awt.event.ActionEvent;
38-
import java.awt.event.KeyEvent;
39-
import java.awt.event.WindowAdapter;
40-
import java.awt.event.WindowEvent;
4137
import java.lang.reflect.Field;
4238
import java.util.ArrayList;
4339
import java.util.Collection;
4440
import java.util.List;
4541
import java.util.Locale;
46-
import javax.swing.JButton;
4742
import javax.swing.JComboBox;
4843
import javax.swing.JComponent;
4944
import javax.swing.JLabel;
5045
import javax.swing.JPanel;
5146
import javax.swing.JTextField;
52-
import javax.swing.KeyStroke;
5347
import javax.swing.event.DocumentEvent;
5448
import org.jetbrains.annotations.NotNull;
5549
import org.jetbrains.annotations.Nullable;
@@ -69,8 +63,6 @@ public class NewObserverDialog extends AbstractDialog {
6963
private final String moduleName;
7064
private final String modulePackage;
7165
private JPanel contentPanel;
72-
private JButton buttonOK;
73-
private JButton buttonCancel;
7466

7567
@FieldValidation(rule = RuleRegistry.NOT_EMPTY,
7668
message = {NotEmptyRule.MESSAGE, OBSERVER_NAME})

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/NewUiComponentGridDialog.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,11 @@
5555
import com.magento.idea.magento2plugin.util.magento.GetModuleNameByDirectoryUtil;
5656
import com.magento.idea.magento2plugin.util.magento.GetResourceCollections;
5757
import java.awt.event.KeyEvent;
58-
import java.awt.event.WindowAdapter;
59-
import java.awt.event.WindowEvent;
6058
import java.util.ArrayList;
6159
import java.util.Arrays;
6260
import java.util.Collection;
6361
import java.util.Collections;
6462
import java.util.List;
65-
import javax.swing.JButton;
6663
import javax.swing.JCheckBox;
6764
import javax.swing.JComponent;
6865
import javax.swing.JLabel;

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/OverrideClassByAPreferenceDialog.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,7 @@
2929
import com.magento.idea.magento2plugin.ui.FilteredComboBox;
3030
import java.awt.event.ActionEvent;
3131
import java.awt.event.KeyEvent;
32-
import java.awt.event.WindowAdapter;
33-
import java.awt.event.WindowEvent;
3432
import java.util.List;
35-
import javax.swing.JButton;
3633
import javax.swing.JCheckBox;
3734
import javax.swing.JComboBox;
3835
import javax.swing.JComponent;

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/OverrideLayoutInThemeDialog.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,12 @@
1919
import com.magento.idea.magento2plugin.magento.packages.Package;
2020
import com.magento.idea.magento2plugin.util.magento.GetMagentoModuleUtil;
2121
import java.awt.event.ActionEvent;
22-
import java.awt.event.KeyEvent;
23-
import java.awt.event.WindowAdapter;
24-
import java.awt.event.WindowEvent;
2522
import java.util.List;
26-
import javax.swing.JButton;
2723
import javax.swing.JComboBox;
2824
import javax.swing.JComponent;
2925
import javax.swing.JLabel;
3026
import javax.swing.JPanel;
3127
import javax.swing.JRadioButton;
32-
import javax.swing.KeyStroke;
3328
import org.jetbrains.annotations.NotNull;
3429
import org.jetbrains.annotations.Nullable;
3530

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/OverrideTemplateInThemeDialog.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,11 @@
1919
import com.magento.idea.magento2plugin.magento.packages.OverridableFileType;
2020
import com.magento.idea.magento2plugin.magento.packages.Package;
2121
import com.magento.idea.magento2plugin.util.magento.GetMagentoModuleUtil;
22-
import java.awt.event.ActionEvent;
23-
import java.awt.event.KeyEvent;
24-
import java.awt.event.WindowAdapter;
25-
import java.awt.event.WindowEvent;
2622
import java.util.List;
27-
import javax.swing.JButton;
2823
import javax.swing.JComboBox;
2924
import javax.swing.JComponent;
3025
import javax.swing.JLabel;
3126
import javax.swing.JPanel;
32-
import javax.swing.KeyStroke;
3327
import org.jetbrains.annotations.NotNull;
3428

3529
public class OverrideTemplateInThemeDialog extends AbstractDialog {
@@ -39,8 +33,6 @@ public class OverrideTemplateInThemeDialog extends AbstractDialog {
3933
private final @NotNull Project project;
4034
private final PsiFile psiFile;
4135
private JPanel contentPane;
42-
private JButton buttonOK;
43-
private JButton buttonCancel;
4436
private JLabel selectTheme; //NOPMD
4537

4638
@FieldValidation(rule = RuleRegistry.NOT_EMPTY,

src/main/java/com/magento/idea/magento2uct/ui/ConfigurationDialog.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@
2424
import com.magento.idea.magento2uct.util.module.UctModulePathValidatorUtil;
2525
import java.awt.Color;
2626
import java.awt.event.KeyEvent;
27-
import java.awt.event.WindowAdapter;
28-
import java.awt.event.WindowEvent;
2927
import java.util.Objects;
3028
import javax.swing.JButton;
3129
import javax.swing.JCheckBox;

src/main/java/com/magento/idea/magento2uct/ui/ReindexDialog.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
import com.magento.idea.magento2uct.packages.IndexRegistry;
1717
import com.magento.idea.magento2uct.packages.SupportedVersion;
1818
import java.awt.event.KeyEvent;
19-
import java.awt.event.WindowAdapter;
20-
import java.awt.event.WindowEvent;
2119
import javax.swing.JButton;
2220
import javax.swing.JComboBox;
2321
import javax.swing.JComponent;

0 commit comments

Comments
 (0)