Skip to content

Commit 97ae063

Browse files
committed
2467: static fix and CHANGELOG.md
1 parent 43f3c87 commit 97ae063

File tree

2 files changed

+14
-7
lines changed

2 files changed

+14
-7
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,18 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0).
66

77
## 5.4.0
88

9+
### Added
10+
11+
- Clear notifications for the process status of URN generation [#2486](https://github.com/magento/magento2-phpstorm-plugin/pull/2486)
12+
913
### Fixed
1014

1115
- Fixed Upgrade Compatibility Tool [#2482](https://github.com/magento/magento2-phpstorm-plugin/pull/2482)
1216
Replaced hardcoded Magento versions with dynamic fetching via Packagist API.
1317
Fixed UI icon references.
1418
Updated Run command.
1519
- java.lang.Throwable: Assertion failed: Do not use PsiElement for popup model. See PsiTargetNavigator [#2485](https://github.com/magento/magento2-phpstorm-plugin/pull/2485)
20+
- Slow operations are prohibited on EDT [#2486](https://github.com/magento/magento2-phpstorm-plugin/pull/2486)
1621

1722
### Changed
1823

src/main/java/com/magento/idea/magento2plugin/project/RegenerateUrnMapListener.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public RegenerateUrnMapListener(final @NotNull Project project) {
4747
*/
4848
@Override
4949
public void mouseClicked(final MouseEvent event) {
50-
final ExternalResourceManager externalResourceManager =
50+
final ExternalResourceManager manager =
5151
ExternalResourceManager.getInstance();
5252
final PsiManager psiManager = PsiManager.getInstance(project);
5353
final MagentoComponentManager componentManager =
@@ -57,14 +57,16 @@ public void mouseClicked(final MouseEvent event) {
5757
new Runnable() {
5858
@Override
5959
public void run() {
60-
final Collection<VirtualFile> xsdFiles = FilenameIndex.getAllFilesByExt(project, "xsd");
61-
final Collection<MagentoComponent> components = componentManager.getAllComponents();
60+
final Collection<VirtualFile> xsdFiles
61+
= FilenameIndex.getAllFilesByExt(project, "xsd");
62+
final Collection<MagentoComponent> components
63+
= componentManager.getAllComponents();
6264
int processedFileCount = 0;
6365

64-
for (final VirtualFile virtualFile : xsdFiles) {
65-
if (handleXsdFile(virtualFile, components, psiManager, externalResourceManager)) {
66+
for (final VirtualFile file : xsdFiles) {
67+
if (handleXsdFile(file, components, psiManager, manager)) {
6668
continue;
67-
};
69+
}
6870

6971
processedFileCount++;
7072
}
@@ -133,7 +135,7 @@ private boolean handleXsdFile(
133135
* indicating the successful completion of URN map generation. Otherwise, a warning notification
134136
* is displayed indicating the failure of URN map generation.
135137
*
136-
* @param processedFileCount The number of files successfully processed for URN mapping generation.
138+
* @param processedFileCount The number of files successfully processed for URN map generation.
137139
*/
138140
private void showNotification(final int processedFileCount) {
139141
if (processedFileCount > 0) {

0 commit comments

Comments
 (0)