MQE-2463: Mftf test extends from a skipped parent should be skipped

Author: jilu1

dev/tests/unit/Magento/FunctionalTestFramework/Test/Util/ObjectExtensionUtilTest.php

@@ -346,6 +346,41 @@ public function testExtendingExtendedActionGroup()
         }
     }
 
+    /**
+     * Tests generating a test that extends a skipped parent test
+     *
+     * @throws \Exception
+     */
+    public function testExtendedTestSkippedParent()
+    {
+        $testDataArrayBuilder = new TestDataArrayBuilder();
+        $mockParentTest = $testDataArrayBuilder
+            ->withName('baseTest')
+            ->withAnnotations([
+                'skip' => ['nodeName' => 'skip', 'issueId' => [['nodeName' => 'issueId', 'value' => 'someIssue']]]
+            ])
+            ->build();
+
+        $testDataArrayBuilder->reset();
+        $mockExtendedTest = $testDataArrayBuilder
+            ->withName('extendTest')
+            ->withTestReference("baseTest")
+            ->build();
+
+        $mockTestData = array_merge($mockParentTest, $mockExtendedTest);
+        $this->setMockTestOutput($mockTestData);
+
+        // parse and generate test object with mocked data
+        TestObjectHandler::getInstance()->getObject('extendTest');
+
+        // validate log statement
+        TestLoggingUtil::getInstance()->validateMockLogStatement(
+            'debug',
+            "extendTest is skipped due to ParentTestIsSkipped",
+            []
+        );
+    }
+
     /**
      * Function used to set mock for parser return and force init method to run between tests.
      *

dev/tests/unit/Util/TestDataArrayBuilder.php

@@ -232,6 +232,28 @@ public function withTestReference($reference = null)
         return $this;
     }
 
+    /**
+     * Reset data array builder
+     *
+     * @return void
+     */
+    public function reset()
+    {
+        // reset
+        $this->testName = 'testTest';
+        $this->filename = null;
+        $this->testActionBeforeName = 'testActionBefore';
+        $this->testActionAfterName = 'testActionAfter';
+        $this->testActionFailedName = 'testActionFailed';
+        $this->testActionType = 'testAction';
+        $this->annotations = [];
+        $this->beforeHook = [];
+        $this->afterHook = [];
+        $this->failedHook = [];
+        $this->testReference = null;
+        $this->testActions = [];
+    }
+
     /**
      * Output the resulting test data array based on parameters set in the object
      *

src/Magento/FunctionalTestingFramework/Test/Util/ObjectExtensionUtil.php

@@ -42,13 +42,13 @@ public function extendTest($testObject)
         try {
             $parentTest = TestObjectHandler::getInstance()->getObject($testObject->getParentName());
         } catch (TestReferenceException $error) {
+            $skippedTest = $this->skipTest($testObject, 'ParentTestDoesNotExist');
             if (MftfApplicationConfig::getConfig()->verboseEnabled()) {
                 LoggingUtil::getInstance()->getLogger(ObjectExtensionUtil::class)->debug(
                     "parent test not defined. test will be skipped",
                     ["parent" => $testObject->getParentName(), "test" => $testObject->getName()]
                 );
             }
-            $skippedTest = $this->skipTest($testObject, 'ParentTestDoesNotExist');
             return $skippedTest;
         }
 
@@ -236,9 +236,11 @@ public function skipTest($testObject, $skipReason = null)
             $testObject->getParentName()
         );
 
-        LoggingUtil::getInstance()->getLogger(ObjectExtensionUtil::class)->info(
-            "\nMQE-2463 LOGGING: {$testObject->getName()} is skipped due to {$skipReason}\n"
-        );
+        if (MftfApplicationConfig::getConfig()->verboseEnabled()) {
+            LoggingUtil::getInstance()->getLogger(ObjectExtensionUtil::class)->debug(
+                "{$testObject->getName()} is skipped due to {$skipReason}"
+            );
+        }
 
         return $skippedTest;
     }