Do not throw \LogicException, as it would break backwards-compatibility.

JanisE · JanisE · commit ae3cbb952db1 · 2017-12-22T22:04:12.000+02:00
diff --git a/lib/internal/Magento/Framework/Module/Dir.php b/lib/internal/Magento/Framework/Module/Dir.php
@@ -45,8 +45,9 @@ public function getDir($moduleName, $type = '')
     {
         $path = $this->componentRegistrar->getPath(ComponentRegistrar::MODULE, $moduleName);
 
-        if (! isset($path)) {
-            throw new \LogicException("Component '$moduleName' of type '$type' is not correctly registered.");
+        if (!isset($path)) {
+            // (Do not throw \LogicException, as it would break backwards-compatibility.)
+            throw new \InvalidArgumentException("Component '$moduleName' of type '$type' is not correctly registered.");
         }
 
         if ($type) {

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,9 @@ public function getDir($moduleName, $type = '')`
`45`	`45`	`{`
`46`	`46`	`$path = $this->componentRegistrar->getPath(ComponentRegistrar::MODULE, $moduleName);`
`47`	`47`
`48`		`- if (! isset($path)) {`
`49`		`- throw new \LogicException("Component '$moduleName' of type '$type' is not correctly registered.");`
	`48`	`+ if (!isset($path)) {`
	`49`	`+ // (Do not throw \LogicException, as it would break backwards-compatibility.)`
	`50`	`+ throw new \InvalidArgumentException("Component '$moduleName' of type '$type' is not correctly registered.");`
`50`	`51`	`}`
`51`	`52`
`52`	`53`	`if ($type) {`