Loose integer check for creditmemo state

Anton Evers · web-flow · commit 8a6c3f2d833b · 2017-10-22T13:54:46.000+06:00
`$creditmemo-&gt;getState() = "1"`
`Creditmemo::STATE_OPEN = 1`
diff --git a/app/code/Magento/Sales/Model/Service/CreditmemoService.php b/app/code/Magento/Sales/Model/Service/CreditmemoService.php
@@ -195,7 +195,7 @@ public function refund(
      */
     protected function validateForRefund(\Magento\Sales\Api\Data\CreditmemoInterface $creditmemo)
     {
-        if ($creditmemo->getId() && $creditmemo->getState() !== \Magento\Sales\Model\Order\Creditmemo::STATE_OPEN) {
+        if ($creditmemo->getId() && $creditmemo->getState() != \Magento\Sales\Model\Order\Creditmemo::STATE_OPEN) {
             throw new \Magento\Framework\Exception\LocalizedException(
                 __('We cannot register an existing credit memo.')
             );

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ public function refund(`
`195`	`195`	`*/`
`196`	`196`	`protected function validateForRefund(\Magento\Sales\Api\Data\CreditmemoInterface $creditmemo)`
`197`	`197`	`{`
`198`		`- if ($creditmemo->getId() && $creditmemo->getState() !== \Magento\Sales\Model\Order\Creditmemo::STATE_OPEN) {`
	`198`	`+ if ($creditmemo->getId() && $creditmemo->getState() != \Magento\Sales\Model\Order\Creditmemo::STATE_OPEN) {`
`199`	`199`	`throw new \Magento\Framework\Exception\LocalizedException(`
`200`	`200`	`__('We cannot register an existing credit memo.')`
`201`	`201`	`);`