Use promoted properties

I removed the addLine() method as it was redundant. The type safety is covered by static analysis.

Author: jdrieghe

src/HtaccessClient.php

@@ -7,13 +7,10 @@
 
 final class HtaccessClient
 {
-    private ClientInterface $httpClient;
-    private ServerRequestFactoryInterface $requestFactory;
-
-    public function __construct(ClientInterface $httpClient, ServerRequestFactoryInterface $requestFactory)
-    {
-        $this->httpClient = $httpClient;
-        $this->requestFactory = $requestFactory;
+    public function __construct(
+        private ClientInterface $httpClient,
+        private ServerRequestFactoryInterface $requestFactory
+    ) {
     }
 
     /**

src/HtaccessResult.php

@@ -5,31 +5,13 @@
 final class HtaccessResult
 {
     /**
-     * @var string
+     * @param ResultLine[] $lines
      */
-    private $outputUrl;
-
-    /**
-     * @var ResultLine[]
-     */
-    private $lines = [];
-
-    /**
-     * @var int?
-     */
-    private $outputStatusCode;
-
     public function __construct(
-        string $outputUrl,
-        array $lines,
-        ?int $outputStatusCode
+        private string $outputUrl,
+        private array $lines,
+        private ?int $outputStatusCode
     ) {
-        $this->outputUrl = $outputUrl;
-        $this->outputStatusCode = $outputStatusCode;
-
-        foreach ($lines as $line) {
-            $this->addLine($line);
-        }
     }
 
     public function getOutputUrl(): string
@@ -49,9 +31,4 @@ public function getOutputStatusCode(): ?int
     {
         return $this->outputStatusCode;
     }
-
-    private function addLine(ResultLine $line): void
-    {
-        $this->lines[] = $line;
-    }
 }