Running Simple Duplex example on Android

[WassimErriha]

Hi David!

I just found out about this library today and I think it's awesome!
I think it will do a lot of the heavy lifting for me once I get a handle on it.

I'm trying to run the Simple Duplex example on Android, but for some reason the data callback is never called.

The stream seems to open successfully with ma_device_init(NULL, &deviceConfig, &device); returning MA_SUCCESS
The Android 12 microphone indicator is turned on ( the green light to the top menu bar that appears when the microphone is being accessed).
Also, the logs don't show any errors.

2022-04-28 09:24:30.944 30019-30019/com.testlib.example I/AAudio: AAudioStreamBuilder_openStream() called ----------------------------------------
2022-04-28 09:24:30.944 30019-30019/com.testlib.example I/AudioStreamBuilder: rate   =      0, channels  = 2, format   = 1, sharing = EX, dir = INPUT
2022-04-28 09:24:30.944 30019-30019/com.testlib.example I/AudioStreamBuilder: device =      0, sessionId = -1, perfMode = 12, callback: ON with frames = 480
2022-04-28 09:24:30.944 30019-30019/com.testlib.example I/AudioStreamBuilder: usage  =      0, contentType = 0, inputPreset = 0, allowedCapturePolicy = 0
2022-04-28 09:24:30.944 30019-30019/com.testlib.example I/AudioStreamBuilder: privacy sensitive = false
2022-04-28 09:24:30.944 30019-30019/com.testlib.example I/AudioStreamBuilder: opPackageName = (null)
2022-04-28 09:24:30.944 30019-30019/com.testlib.example I/AudioStreamBuilder: attributionTag = (null)
2022-04-28 09:24:30.944 30019-30019/com.testlib.example D/testlib.exampl: PlayerBase::PlayerBase()
2022-04-28 09:24:31.042 30019-30019/com.testlib.example D/testlib.exampl: PlayerBase::PlayerBase()
2022-04-28 09:24:31.042 30019-30019/com.testlib.example D/AudioStreamInternal_Client: ~AudioStreamInternal() 0xb400006ea8d7b610 called
2022-04-28 09:24:31.042 30019-30019/com.testlib.example D/AAudioStream: ~AudioStream(s#1) mPlayerBase strongCount = 1
2022-04-28 09:24:31.042 30019-30019/com.testlib.example D/testlib.exampl: PlayerBase::~PlayerBase()
2022-04-28 09:24:31.066 30019-30019/com.testlib.example I/AudioRecord: createRecord_l(0): AUDIO_INPUT_FLAG_FAST successful; frameCount 1440 -> 4096
2022-04-28 09:24:31.067 30019-30019/com.testlib.example W/AudioStreamRecord: open() flags changed from 0x00000005 to 0x00000001
2022-04-28 09:24:31.067 30019-30019/com.testlib.example D/AAudioStream: setState(s#2) from 0 to 2
2022-04-28 09:24:31.069 30019-30019/com.testlib.example I/AAudio: AAudioStreamBuilder_openStream() returns 0 = AAUDIO_OK for s#2 ----------------
2022-04-28 09:24:31.069 30019-30019/com.testlib.example I/AAudio: AAudioStreamBuilder_openStream() called ----------------------------------------
2022-04-28 09:24:31.069 30019-30019/com.testlib.example I/AudioStreamBuilder: rate   =      0, channels  = 2, format   = 1, sharing = SH, dir = OUTPUT
2022-04-28 09:24:31.069 30019-30019/com.testlib.example I/AudioStreamBuilder: device =      0, sessionId = -1, perfMode = 12, callback: ON with frames = 480
2022-04-28 09:24:31.069 30019-30019/com.testlib.example I/AudioStreamBuilder: usage  =      0, contentType = 0, inputPreset = 0, allowedCapturePolicy = 0
2022-04-28 09:24:31.069 30019-30019/com.testlib.example I/AudioStreamBuilder: privacy sensitive = false
2022-04-28 09:24:31.069 30019-30019/com.testlib.example I/AudioStreamBuilder: opPackageName = (null)
2022-04-28 09:24:31.069 30019-30019/com.testlib.example I/AudioStreamBuilder: attributionTag = (null)
2022-04-28 09:24:31.069 30019-30019/com.testlib.example D/testlib.exampl: PlayerBase::PlayerBase()
2022-04-28 09:24:31.084 30019-30019/com.testlib.example D/AudioStreamInternal_Client: open() original HW burst = 96, minMicros = 2000 => SW burst = 96
2022-04-28 09:24:31.084 30019-30019/com.testlib.example D/AAudioStream: setState(s#3) from 0 to 2
2022-04-28 09:24:31.084 30019-30019/com.testlib.example I/AAudioFlowGraph: configure() source format = 0x00000001, channels = 2, sink format = 0x00000005, channels = 2
2022-04-28 09:24:31.086 30019-30019/com.testlib.example I/AAudio: AAudioStreamBuilder_openStream() returns 0 = AAUDIO_OK for s#3 ----------------
2022-04-28 09:24:31.086 30019-30019/com.testlib.example D/AAudio: AAudioStream_requestStart(s#2) called --------------
2022-04-28 09:24:31.086 30019-30019/com.testlib.example D/AAudioStream: setState(s#2) from 2 to 3
2022-04-28 09:24:31.116 30019-30019/com.testlib.example D/AAudio: AAudioStream_requestStart(s#2) returned 0 ---------
2022-04-28 09:24:31.116 30019-30039/com.testlib.example D/AudioStreamLegacy: onAudioDeviceUpdate(deviceId = 31878)
2022-04-28 09:24:31.116 30019-30039/com.testlib.example D/AudioStreamLegacy: onAudioDeviceUpdate(deviceId = 31878)
2022-04-28 09:24:31.171 30019-30089/com.testlib.example D/AAudioStream: setState(s#2) from 3 to 4
2022-04-28 09:24:31.176 30019-30019/com.testlib.example D/AAudio: AAudioStream_requestStart(s#3) called --------------
2022-04-28 09:24:31.176 30019-30019/com.testlib.example D/AAudioStream: setState(s#3) from 2 to 3
2022-04-28 09:24:31.233 30019-30019/com.testlib.example D/AAudio: AAudioStream_requestStart(s#3) returned 0 ---------
2022-04-28 09:24:31.233 30019-30120/com.testlib.example D/AudioStreamInternalPlay_Client: callbackLoop() entering >>>>>>>>>>>>>>>
2022-04-28 09:24:31.233 30019-30120/com.testlib.example D/AudioStreamInternal_Client: onEventFromServer - got AAUDIO_SERVICE_EVENT_STARTED
2022-04-28 09:24:31.233 30019-30120/com.testlib.example D/AAudioStream: setState(s#3) from 3 to 4

This is my first time reading C code, so, I'm guessing I might be missing a step or something.
I Tried running the example as-is at first, but the stream was being started and then stopped. So I commented-out the lines that I thought weren't meant for android (commented lines not included in the sample below).

#define MINIAUDIO_IMPLEMENTATION
#include "miniaudio.h"
#include <android/log.h>
#include <stdio.h>


void data_callback(ma_device* pDevice, void* pOutput, const void* pInput, ma_uint32 frameCount)
{
    __android_log_print(ANDROID_LOG_DEBUG, "Simple Duplex", "%s", "DATA CALLBACK");
    
    MA_ASSERT(pDevice->capture.format == pDevice->playback.format);
    MA_ASSERT(pDevice->capture.channels == pDevice->playback.channels);
    
    MA_COPY_MEMORY(pOutput, pInput, frameCount * ma_get_bytes_per_frame(
            pDevice->capture.format, 
            pDevice->capture.channels));
}


JNIEXPORT jint JNICALL
Java_com_testlib_example_MainActivity_test(
        JNIEnv *env, 
        jobject 
        thiz, 
        jint inputDeviceID,
        jint outputDeviceID) {
    
    ma_result result;
    ma_device_config deviceConfig;
    ma_device device;
    deviceConfig = ma_device_config_init(ma_device_type_duplex);
    deviceConfig.capture.pDeviceID  = NULL;
    deviceConfig.capture.format     = ma_format_s16;
    deviceConfig.capture.channels   = 2;
    deviceConfig.capture.shareMode  = ma_share_mode_exclusive;
    deviceConfig.playback.pDeviceID = NULL;
    deviceConfig.playback.format    = ma_format_s16;
    deviceConfig.playback.channels  = 2;
    deviceConfig.dataCallback       = data_callback;
    
    result = ma_device_init(NULL, &deviceConfig, &device);
    if (result != MA_SUCCESS) {
        __android_log_print(ANDROID_LOG_ERROR, "Simple Duplex", "%s", "Init audio device failed");
        return result;
    }

    ma_device_start(&device);
    // ma_device_start__aaudio(&device);
    
    return 0;
}

I also tried iterating through the available device IDs (on the java side), and passed my wired headset's source and sink device ID's to the deviceConfig , but the app crashes with

A/libc: Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x7c85 in tid 5449 (testlib.example), pid 5449 (testlib.example)

Maybe I'm not handling the type casting properly.

    deviceConfig.capture.pDeviceID  = (const ma_device_id *) inputDeviceID;
    deviceConfig.playback.pDeviceID = (const ma_device_id *) outputDeviceID;

[WassimErriha]

This was tested on Samsung Galaxy S10 (Android 12) and Samsung Galaxy S7 (Android 8)
Unfortunately, I don't have access to any other devices at the moment.
If the code above is not missing any steps, maybe I'll try finding a non-Samsung device to test on.
I know that Samsung phones are a pain when it comes to Audio. I came across multiple threads on Google's Oboe issue tracker and Samsung devices seem to come up fairly often.

[mackron]

So there's a couple of things wrong here. The ma_device object (and all objects in miniaudio for that matter) are transparent structs and not references. You're declaring the ma_device object on the stack, but then as soon as ma_device_start() returns, you're returning from Java_com_testlib_example_MainActivity_test() which will be destroying your ma_device object. The ma_device_config struct is not used after ma_device_init(), so it's fine to leave that on the stack. I'm suspecting this might be the cause of your issues with this one.

The device ID thing is incorrect. You would probably want to do something like this:

deviceConfig.capture.pDeviceID.aaudio = inputDeviceID;

[WassimErriha]

Oh yeah, I did read about that in the documentation, but I still managed to miss it.
The example works as expected.
Thank you for the quick response!

[mackron]

Glad that's working for you.

As a side note, if you ever end up implementing that thing where you iterate over the available device in Java and pass in the device ID, I'd be curious to hear how you go with that. I'm not aware of anybody whose implemented it. The advice I've given in the documentation was from information I found online elsewhere and I've not actually been able to test it for myself.

[WassimErriha]

There were two inline compiler errors, so I changed . to -> in deviceConfig.capture.pDeviceID->aaudio = inputDeviceID; and removed const at lines 6582 and 6591.

deviceConfig.capture.pDeviceID->aaudio = inputDeviceID;
deviceConfig.playback.pDeviceID->aaudio = outputDeviceID;

This caused a crash. (last line in the log)

D/AudioDeviceConnections: Number Of Available Audio Devices : 9
D/AudioDeviceConnections:  
     	 Device Name : SM-G973W
     	 Device ID : 2
     	 Device Type : built-in earphone speaker
     	 Device Direction Type : Output Device
D/AudioDeviceConnections:  
     	 Device Name : SM-G973W
     	 Device ID : 3
     	 Device Type : built-in speaker
     	 Device Direction Type : Output Device
D/AudioDeviceConnections:  
     	 Device Name : h2w
     	 Device ID : 33951
     	 Device Type : wired headset
     	 Device Direction Type : Output Device
D/AudioDeviceConnections:  
     	 Device Name : SM-G973W
     	 Device ID : 14
     	 Device Type : telephony
     	 Device Direction Type : Output Device
D/AudioDeviceConnections:  
     	 Device Name : SM-G973W
     	 Device ID : 17
     	 Device Type : built-in microphone
     	 Device Direction Type : Input Device
D/AudioDeviceConnections:  
     	 Device Name : h2w
     	 Device ID : 33952
     	 Device Type : wired headset
     	 Device Direction Type : Input Device
D/AudioDeviceConnections:  
     	 Device Name : SM-G973W
     	 Device ID : 18
     	 Device Type : telephony
     	 Device Direction Type : Input Device
D/AudioDeviceConnections:  
     	 Device Name : SM-G973W
     	 Device ID : 19
     	 Device Type : built-in microphone
     	 Device Direction Type : Input Device
D/AudioDeviceConnections:  
     	 Device Name : SM-G973W
     	 Device ID : 23
     	 Device Type : unknown
     	 Device Direction Type : Input Device
A/libc: Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0 in tid 2124 (testlib.example), pid 2124 (testlib.example)

Passing NULL shows a check Incompatible pointer to integer conversion assigning to 'ma_int32' (aka 'int') from 'void *' and it also crashes the app with the same log.

Passing NULL as before, works as expected.

    deviceConfig.capture.pDeviceID  = NULL;
    deviceConfig.playback.pDeviceID = NULL;

[mackron]

Yeah that code I posted was just part of it. You would need to actually allocate a ma_device_id object somewhere and set the pDeviceID variable to a pointer to it. I was mostly just curious - don't spend any time on it if don't need that feature.