bext size allocation error

scjurgen · mackron · commit 92844c5c07f0 · 2025-05-30T08:30:23.000+10:00
on line 2531 the reader consumes one byte too much (extraBytes + 1). This can cause a DRWAV_ASSERT.
diff --git a/dr_wav.h b/dr_wav.h
@@ -2811,7 +2811,7 @@ DRWAV_PRIVATE drwav_uint64 drwav__metadata_process_chunk(drwav__metadata_parser*
                     return bytesRead;
                 }
                 allocSizeNeeded += drwav__strlen(buffer) + 1;
-                allocSizeNeeded += (size_t)pChunkHeader->sizeInBytes - DRWAV_BEXT_BYTES; /* Coding history. */
+                allocSizeNeeded += (size_t)pChunkHeader->sizeInBytes - DRWAV_BEXT_BYTES + 1; /* Coding history. */
 
                 drwav__metadata_request_extra_memory_for_stage_2(pParser, allocSizeNeeded, 1);
 

Original file line number	Diff line number	Diff line change
`@@ -2811,7 +2811,7 @@ DRWAV_PRIVATE drwav_uint64 drwav__metadata_process_chunk(drwav__metadata_parser*`
`2811`	`2811`	`return bytesRead;`
`2812`	`2812`	`}`
`2813`	`2813`	`allocSizeNeeded += drwav__strlen(buffer) + 1;`
`2814`		`- allocSizeNeeded += (size_t)pChunkHeader->sizeInBytes - DRWAV_BEXT_BYTES; /* Coding history. */`
	`2814`	`+ allocSizeNeeded += (size_t)pChunkHeader->sizeInBytes - DRWAV_BEXT_BYTES + 1; /* Coding history. */`
`2815`	`2815`
`2816`	`2816`	`drwav__metadata_request_extra_memory_for_stage_2(pParser, allocSizeNeeded, 1);`
`2817`	`2817`