From 90f1d0a881a21a8b4f192622d798c290770fda63 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jim=20Teichgr=C3=A4ber?= Date: Fri, 11 Jul 2025 10:16:25 +0200 Subject: [PATCH 1/3] set legacy PM UniformityInfoWrapperPass isCFGOnly to false --- llvm/lib/Analysis/UniformityAnalysis.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/llvm/lib/Analysis/UniformityAnalysis.cpp b/llvm/lib/Analysis/UniformityAnalysis.cpp index 2101fdfacfc8f..0daf4041a72f3 100644 --- a/llvm/lib/Analysis/UniformityAnalysis.cpp +++ b/llvm/lib/Analysis/UniformityAnalysis.cpp @@ -150,8 +150,11 @@ INITIALIZE_PASS_BEGIN(UniformityInfoWrapperPass, "uniformity", INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass) INITIALIZE_PASS_DEPENDENCY(CycleInfoWrapperPass) INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass) +// Though Uniformity Analysis depends on the CFG, +// it also needs to be invalidated if values are changed, so isCFGOnly: false. +// See NOTE on updatability at the start of GenericUniformityImpl.h INITIALIZE_PASS_END(UniformityInfoWrapperPass, "uniformity", - "Uniformity Analysis", true, true) + "Uniformity Analysis", false, true) void UniformityInfoWrapperPass::getAnalysisUsage(AnalysisUsage &AU) const { AU.setPreservesAll(); From fceacd0651bdba8b8381e448a9baaf9627627d98 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jim=20Teichgr=C3=A4ber?= Date: Fri, 11 Jul 2025 16:37:13 +0200 Subject: [PATCH 2/3] also change isCFGOnly in BEGIN macro --- llvm/lib/Analysis/UniformityAnalysis.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/lib/Analysis/UniformityAnalysis.cpp b/llvm/lib/Analysis/UniformityAnalysis.cpp index 0daf4041a72f3..772a1e50934f8 100644 --- a/llvm/lib/Analysis/UniformityAnalysis.cpp +++ b/llvm/lib/Analysis/UniformityAnalysis.cpp @@ -146,7 +146,7 @@ char UniformityInfoWrapperPass::ID = 0; UniformityInfoWrapperPass::UniformityInfoWrapperPass() : FunctionPass(ID) {} INITIALIZE_PASS_BEGIN(UniformityInfoWrapperPass, "uniformity", - "Uniformity Analysis", true, true) + "Uniformity Analysis", false, true) INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass) INITIALIZE_PASS_DEPENDENCY(CycleInfoWrapperPass) INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass) From d64e5cbae75df840214e2d3917dddd84948f793f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jim=20Teichgr=C3=A4ber?= Date: Fri, 11 Jul 2025 16:37:26 +0200 Subject: [PATCH 3/3] [NFC] get rid of comment as discussed --- llvm/lib/Analysis/UniformityAnalysis.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/llvm/lib/Analysis/UniformityAnalysis.cpp b/llvm/lib/Analysis/UniformityAnalysis.cpp index 772a1e50934f8..15107c262980c 100644 --- a/llvm/lib/Analysis/UniformityAnalysis.cpp +++ b/llvm/lib/Analysis/UniformityAnalysis.cpp @@ -150,9 +150,6 @@ INITIALIZE_PASS_BEGIN(UniformityInfoWrapperPass, "uniformity", INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass) INITIALIZE_PASS_DEPENDENCY(CycleInfoWrapperPass) INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass) -// Though Uniformity Analysis depends on the CFG, -// it also needs to be invalidated if values are changed, so isCFGOnly: false. -// See NOTE on updatability at the start of GenericUniformityImpl.h INITIALIZE_PASS_END(UniformityInfoWrapperPass, "uniformity", "Uniformity Analysis", false, true)