-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[libc] implement ioctl #85275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi! This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:
If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below. |
@llvm/issue-subscribers-good-first-issue Author: Nick Desaulniers (nickdesaulniers)
the ioctl syscall is pretty important, and is used by libc++ for LIBCXX_ENABLE_RANDOM_DEVICE support.
We currently define a few macros for ioctl in include/llvm-libc-macros/sys-ioctl-macros.h and generate ioctl.h via include/sys/ioctl.h.def. I also see open coded calls to ioctl in:
I assume once ioctl is implemented, all of the above open coded calls should be replaced with the call to our internal wrapper. |
@llvm/issue-subscribers-libc Author: Nick Desaulniers (nickdesaulniers)
the ioctl syscall is pretty important, and is used by libc++ for LIBCXX_ENABLE_RANDOM_DEVICE support.
We currently define a few macros for ioctl in include/llvm-libc-macros/sys-ioctl-macros.h and generate ioctl.h via include/sys/ioctl.h.def. I also see open coded calls to ioctl in:
I assume once ioctl is implemented, all of the above open coded calls should be replaced with the call to our internal wrapper. |
Hi I am interested in this issue, can this be assigned to me? Thanks. |
Hi @changkhothuychung , thanks for your interest! This one will be interesting, since the 048041f is probably a good example of adding a new entry that's specific to linux. I'd use that as a reference for the boilerplate that needs to be added. Terrifyingly, POSIX seems to have standardized this interface, under a different header and with a different signature than what is used in linux. I'll probably have to do some more digging into the history there, but for now, please provide an implementation based on the signature and header as specified by |
@nickdesaulniers Thank you very much for the instructions! I will start working on it and will make a PR as soon as I have some progress. |
@nickdesaulniers do you have any documentations about building and testing libc? Thanks. |
This PR is to work on the issue #85275
Uh oh!
There was an error while loading. Please reload this page.
the ioctl syscall is pretty important, and is used by libc++ for LIBCXX_ENABLE_RANDOM_DEVICE support.
We currently define a few macros for ioctl in include/llvm-libc-macros/sys-ioctl-macros.h and generate ioctl.h via include/sys/ioctl.h.def.
I also see open coded calls to ioctl in:
I assume once ioctl is implemented, all of the above open coded calls should be replaced with the call to our internal wrapper.
The text was updated successfully, but these errors were encountered: