Remove unneeded check

AmrDeveloper · AmrDeveloper · commit 93f8f02f199a · 2025-07-02T18:06:08.000+02:00
diff --git a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
@@ -907,9 +907,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
       assert(e->getOpcode() == BO_EQ || e->getOpcode() == BO_NE);
 
       BinOpInfo boInfo = emitBinOps(e);
-      cir::CmpOpKind opKind =
-          e->getOpcode() == BO_EQ ? cir::CmpOpKind::eq : cir::CmpOpKind::ne;
-      result = builder.create<cir::CmpOp>(loc, opKind, boInfo.lhs, boInfo.rhs);
+      result = builder.create<cir::CmpOp>(loc, kind, boInfo.lhs, boInfo.rhs);
     }
 
     return emitScalarConversion(result, cgf.getContext().BoolTy, e->getType(),

Original file line number	Diff line number	Diff line change
`@@ -907,9 +907,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {`
`907`	`907`	`assert(e->getOpcode() == BO_EQ \|\| e->getOpcode() == BO_NE);`
`908`	`908`
`909`	`909`	`BinOpInfo boInfo = emitBinOps(e);`
`910`		`- cir::CmpOpKind opKind =`
`911`		`- e->getOpcode() == BO_EQ ? cir::CmpOpKind::eq : cir::CmpOpKind::ne;`
`912`		`- result = builder.create<cir::CmpOp>(loc, opKind, boInfo.lhs, boInfo.rhs);`
	`910`	`+ result = builder.create<cir::CmpOp>(loc, kind, boInfo.lhs, boInfo.rhs);`
`913`	`911`	`}`
`914`	`912`
`915`	`913`	`return emitScalarConversion(result, cgf.getContext().BoolTy, e->getType(),`