Don't fail the pass if some op fails to get a more static shape

nicolasvasilache · nicolasvasilache · commit 7736abb7a0c0 · 2025-06-27T10:52:40.000+02:00
diff --git a/mlir/lib/Dialect/MemRef/Transforms/ReifyResultShapes.cpp b/mlir/lib/Dialect/MemRef/Transforms/ReifyResultShapes.cpp
@@ -138,7 +138,6 @@ void ReifyResultShapesPass::runOnOperation() {
   IRRewriter rewriter(&getContext());
   for (ReifyRankedShapedTypeOpInterface op : ops) {
     rewriter.setInsertionPoint(op);
-    if (failed(memref::reifyOpResultShapes(rewriter, op)))
-      return signalPassFailure();
+    (void)memref::reifyOpResultShapes(rewriter, op);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,6 @@ void ReifyResultShapesPass::runOnOperation() {`
`138`	`138`	`IRRewriter rewriter(&getContext());`
`139`	`139`	`for (ReifyRankedShapedTypeOpInterface op : ops) {`
`140`	`140`	`rewriter.setInsertionPoint(op);`
`141`		`- if (failed(memref::reifyOpResultShapes(rewriter, op)))`
`142`		`- return signalPassFailure();`
	`141`	`+ (void)memref::reifyOpResultShapes(rewriter, op);`
`143`	`142`	`}`
`144`	`143`	`}`