Remove unneeded check

AmrDeveloper · AmrDeveloper · commit 187fd85eabbb · 2025-06-28T10:55:15.000+02:00
diff --git a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
@@ -901,9 +901,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
       assert(e->getOpcode() == BO_EQ || e->getOpcode() == BO_NE);
 
       BinOpInfo boInfo = emitBinOps(e);
-      cir::CmpOpKind opKind =
-          e->getOpcode() == BO_EQ ? cir::CmpOpKind::eq : cir::CmpOpKind::ne;
-      result = builder.create<cir::CmpOp>(loc, opKind, boInfo.lhs, boInfo.rhs);
+      result = builder.create<cir::CmpOp>(loc, kind, boInfo.lhs, boInfo.rhs);
     }
 
     return emitScalarConversion(result, cgf.getContext().BoolTy, e->getType(),

Original file line number	Diff line number	Diff line change
`@@ -901,9 +901,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {`
`901`	`901`	`assert(e->getOpcode() == BO_EQ \|\| e->getOpcode() == BO_NE);`
`902`	`902`
`903`	`903`	`BinOpInfo boInfo = emitBinOps(e);`
`904`		`- cir::CmpOpKind opKind =`
`905`		`- e->getOpcode() == BO_EQ ? cir::CmpOpKind::eq : cir::CmpOpKind::ne;`
`906`		`- result = builder.create<cir::CmpOp>(loc, opKind, boInfo.lhs, boInfo.rhs);`
	`904`	`+ result = builder.create<cir::CmpOp>(loc, kind, boInfo.lhs, boInfo.rhs);`
`907`	`905`	`}`
`908`	`906`
`909`	`907`	`return emitScalarConversion(result, cgf.getContext().BoolTy, e->getType(),`