cgroup_xattr: Remove unused variable

The dir variable in mount_cgroup() is uninitialized but it gets
printed into error messages instead of the correct opt->dir. Remove
the variable and fix the error message.

Link: https://lore.kernel.org/ltp/[email protected]/
Fixes: 0e335db ("New core test of cgroups and extended attributes")
Reviewed-by: Andrea Cervesato <[email protected]>
Reviewed-by: Petr Vorel <[email protected]>
Signed-off-by: Martin Doucha <[email protected]>

Author: mdoucha

testcases/kernel/controllers/cgroup_xattr/cgroup_xattr.c

@@ -289,15 +289,14 @@ int mount_cgroup(void)
 
 	int i, any_mounted = 0;
 	for (i = 0; i < cgrp_opt_num; ++i) {
-		char dir[MAX_DIR_NAME];
 		struct cgrp_option *opt = &cgrp_opt[i];
 		tst_resm(TINFO, "mount options %d: %s (hier = %d)",
 			i, opt->str, opt->hier);
 		snprintf(opt->dir, MAX_DIR_NAME, "cgx_%d", opt->hier);
 		SAFE_MKDIR(cleanup, opt->dir, 0755);
 
 		if (mount(opt->dir, opt->dir, "cgroup", 0, opt->str) == -1) {
-			tst_resm(TINFO, "Can't mount: %s", dir);
+			tst_resm(TINFO, "Can't mount: %s", opt->dir);
 			continue;
 		}