Only call va_start when needed

gaul · gaul · commit 49f544fd8d59 · 2019-11-24T16:09:31.000+09:00
diff --git a/src/util.c b/src/util.c
@@ -8,11 +8,11 @@
 void mbp_log(int level, const char *fmt, ...)
 {
     va_list args;
-    va_start(args, fmt);
     if (daemonize) {
+        va_start(args, fmt);
         vsyslog(level, fmt, args);
+        va_end(args);
     }
-    va_end(args);
 
     va_start(args, fmt);
     vprintf(fmt, args);

Original file line number	Diff line number	Diff line change
`@@ -8,11 +8,11 @@`
`8`	`8`	`void mbp_log(int level, const char *fmt, ...)`
`9`	`9`	`{`
`10`	`10`	`va_list args;`
`11`		`- va_start(args, fmt);`
`12`	`11`	`if (daemonize) {`
	`12`	`+ va_start(args, fmt);`
`13`	`13`	`vsyslog(level, fmt, args);`
	`14`	`+ va_end(args);`
`14`	`15`	`}`
`15`		`- va_end(args);`
`16`	`16`
`17`	`17`	`va_start(args, fmt);`
`18`	`18`	`vprintf(fmt, args);`