Skip to content

Commit ad49dff

Browse files
testing fixes for flaking (#788)
1 parent 8fe2a0a commit ad49dff

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

internal/controller/linodemachine_controller_test.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1692,7 +1692,7 @@ var _ = Describe("machine-update", Ordered, Label("machine", "machine-update"),
16921692
Status: linodego.InstanceRunning,
16931693
Updated: util.Pointer(time.Now()),
16941694
}, nil)
1695-
mck.LinodeClient.EXPECT().UpdateInstance(ctx, 11111, linodego.InstanceUpdateOptions{Tags: &[]string{"test-tag", "test-cluster-2"}}).Return(
1695+
mck.LinodeClient.EXPECT().UpdateInstance(ctx, 11111, gomock.Any()).Return(
16961696
&linodego.Instance{
16971697
ID: 11111,
16981698
IPv4: []*net.IP{ptr.To(net.IPv4(192, 168, 0, 2))},
@@ -1799,15 +1799,14 @@ var _ = Describe("machine-delete", Ordered, Label("machine", "machine-delete"),
17991799
linodeMachine.Spec.ProviderID = tmpProviderID
18001800

18011801
})),
1802-
/* TODO: fix this flaking test
1803-
Path(Result("delete requeues", func(ctx context.Context, mck Mock) {
1802+
Path(Result("delete requeues", func(ctx context.Context, mck Mock) {
18041803
mck.LinodeClient.EXPECT().DeleteInstance(gomock.Any(), gomock.Any()).
1805-
Return(&linodego.Error{Code: http.StatusInternalServerError})
1804+
Return(&linodego.Error{Code: http.StatusBadGateway})
18061805
res, err := reconciler.reconcileDelete(ctx, mck.Logger(), mScope)
18071806
Expect(err).NotTo(HaveOccurred())
18081807
Expect(res.RequeueAfter).To(Equal(rutil.DefaultMachineControllerRetryDelay))
18091808
Expect(mck.Logs()).To(ContainSubstring("re-queuing Linode instance deletion"))
1810-
})), */
1809+
})),
18111810
),
18121811
),
18131812
Path(

0 commit comments

Comments
 (0)