Renamed Parameter to reflect actual behavior

linkdotnet · linkdotnet · commit 3d9f170e7ace · 2022-03-03T12:43:23.000+01:00
diff --git a/src/LinkDotNet.Blog.Web/Features/AboutMe/AboutMePage.razor b/src/LinkDotNet.Blog.Web/Features/AboutMe/AboutMePage.razor
@@ -15,13 +15,13 @@
     <div class="container">
         <div class="row">
             <div class="col-lg-3 col-md-4">
-                <Profile IsAuthenticated="@isAuthenticated"/>
+                <Profile ShowAdminActions="@isAuthenticated"/>
             </div>
             <div class="col-lg-9 col-md-8 tab-container">
                 <div class="row">
                     <div class="col-md12 tab-content">
                         <Card Header="Skills">
-                            <SkillTable IsAuthenticated="@isAuthenticated"></SkillTable>
+                            <SkillTable ShowAdminActions="@isAuthenticated"></SkillTable>
                         </Card>
                     </div>
                 </div>
diff --git a/src/LinkDotNet.Blog.Web/Features/AboutMe/Components/Card.razor b/src/LinkDotNet.Blog.Web/Features/AboutMe/Components/Card.razor
@@ -9,6 +9,7 @@
 @code {
     [Parameter]
     public string Header { get; set; }
+
     [Parameter]
     public RenderFragment ChildContent { get; set; }
 }
diff --git a/src/LinkDotNet.Blog.Web/Features/AboutMe/Components/Profile.razor b/src/LinkDotNet.Blog.Web/Features/AboutMe/Components/Profile.razor
@@ -20,7 +20,7 @@
         ondragover="event.preventDefault();">
         @foreach (var entry in profileInformationEntries)
         {
-            @if (IsAuthenticated)
+            @if (ShowAdminActions)
             {
                 <li
                     class="item-draggable"
@@ -39,7 +39,7 @@
                 <li>@RenderMarkupString(entry.Content)</li>
             }
         }
-        @if (IsAuthenticated)
+        @if (ShowAdminActions)
         {
             <AddProfileShortItem ValueAdded="@AddValue"></AddProfileShortItem>
         }
@@ -51,7 +51,7 @@ OnYesPressed="DeleteItem"></ConfirmDialog>
 
 @code {
     [Parameter]
-    public bool IsAuthenticated { get; set; }
+    public bool ShowAdminActions { get; set; }
 
     private List<ProfileInformationEntry> profileInformationEntries = new();
     private ConfirmDialog Dialog { get; set; }
diff --git a/src/LinkDotNet.Blog.Web/Features/AboutMe/Components/SkillTable.razor b/src/LinkDotNet.Blog.Web/Features/AboutMe/Components/SkillTable.razor
@@ -2,7 +2,7 @@
 @using LinkDotNet.Blog.Infrastructure.Persistence
 @inject IRepository<Skill> repository
 <div>
-        @if (IsAuthenticated)
+        @if (ShowAdminActions)
         {
             <button type="button" class="btn btn-primary" @onclick="() => AddSkillDialog.Open()"><i class="fas
             fa-plus-square"></i>
@@ -28,12 +28,12 @@
                     <td @ondrop="@(() => HandleDrop(skillLevel))" class="proficiency-level">
                         @foreach (var skill in skillCapabilityGroup.Where(s => s.ProficiencyLevel == skillLevel))
                         {
-                            @if (IsAuthenticated)
+                            @if (ShowAdminActions)
                             {
                                 <div draggable="true" @ondrag="@(() => currentDragItem = skill)" style="cursor: grab"
                                  class="skill-tag">
                                     <SkillTag Skill="@skill"
-                                              IsAuthenticated="@true"
+                                              ShowAdminActions="@true"
                                               DeleteSkill="@(() => DeleteSkill(skill))"/>
                                 </div>
                             }
@@ -50,14 +50,14 @@
         }
         </tbody>
     </table>
-    @if (IsAuthenticated)
+    @if (ShowAdminActions)
     {
         <small for="skill-table">You can drag and drop your skills from one proficency to another</small>
     }
 </div>
 @code {
     [Parameter]
-    public bool IsAuthenticated { get; set; }
+    public bool ShowAdminActions { get; set; }
 
     private AddSkillDialog AddSkillDialog { get; set; }
 
diff --git a/src/LinkDotNet.Blog.Web/Features/AboutMe/Components/SkillTag.razor b/src/LinkDotNet.Blog.Web/Features/AboutMe/Components/SkillTag.razor
@@ -6,7 +6,7 @@
     }
     @Skill.Name
 
-    @if (IsAuthenticated)
+    @if (ShowAdminActions)
     {
         <button type="button" class="btn btn-default" aria-label="Delete Skill" @onclick="() => DeleteSkill.InvokeAsync()">
             <i class="fas fa-trash-alt" aria-hidden="true"></i>
@@ -19,7 +19,7 @@
     public Skill Skill { get; set; }
 
     [Parameter]
-    public bool IsAuthenticated { get; set; }
+    public bool ShowAdminActions { get; set; }
 
     [Parameter]
     public EventCallback DeleteSkill { get; set; }
diff --git a/tests/LinkDotNet.Blog.IntegrationTests/Web/Shared/ProfileTests.cs b/tests/LinkDotNet.Blog.IntegrationTests/Web/Shared/ProfileTests.cs
@@ -43,7 +43,7 @@ public void ShouldNotShowAdminActions()
     public void ShouldShowAdminActionsWhenLoggedIn()
     {
         RegisterServices();
-        RenderComponent<Profile>(p => p.Add(s => s.IsAuthenticated, true))
+        RenderComponent<Profile>(p => p.Add(s => s.ShowAdminActions, true))
             .FindComponents<AddProfileShortItem>().Should().HaveCount(1);
     }
 
@@ -54,7 +54,7 @@ public void ShouldAddEntry()
         ProfileInformationEntry entryToDb = null;
         repo.Setup(p => p.StoreAsync(It.IsAny<ProfileInformationEntry>()))
             .Callback<ProfileInformationEntry>(p => entryToDb = p);
-        var cut = RenderComponent<Profile>(p => p.Add(s => s.IsAuthenticated, true));
+        var cut = RenderComponent<Profile>(p => p.Add(s => s.ShowAdminActions, true));
         var addShortItemComponent = cut.FindComponent<AddProfileShortItem>();
         addShortItemComponent.Find("input").Change("key");
 
@@ -72,7 +72,7 @@ public void ShouldDeleteEntryWhenConfirmed()
         entryToDelete.Id = "SomeId";
         var (repoMock, _) = RegisterServices();
         SetupGetAll(repoMock, entryToDelete);
-        var cut = RenderComponent<Profile>(p => p.Add(s => s.IsAuthenticated, true));
+        var cut = RenderComponent<Profile>(p => p.Add(s => s.ShowAdminActions, true));
         cut.Find(".profile-keypoints li button").Click();
 
         cut.FindComponent<ConfirmDialog>().Find("#ok").Click();
@@ -87,7 +87,7 @@ public void ShouldNotDeleteEntryWhenNotConfirmed()
         entryToDelete.Id = "SomeId";
         var (repoMock, _) = RegisterServices();
         SetupGetAll(repoMock, entryToDelete);
-        var cut = RenderComponent<Profile>(p => p.Add(s => s.IsAuthenticated, true));
+        var cut = RenderComponent<Profile>(p => p.Add(s => s.ShowAdminActions, true));
         cut.Find(".profile-keypoints li button").Click();
 
         cut.FindComponent<ConfirmDialog>().Find("#cancel").Click();
@@ -104,7 +104,7 @@ public void ShouldAddEntryWithCorrectSortOrder()
         ProfileInformationEntry entryToDb = null;
         repo.Setup(p => p.StoreAsync(It.IsAny<ProfileInformationEntry>()))
             .Callback<ProfileInformationEntry>(p => entryToDb = p);
-        var cut = RenderComponent<Profile>(p => p.Add(s => s.IsAuthenticated, true));
+        var cut = RenderComponent<Profile>(p => p.Add(s => s.ShowAdminActions, true));
         var addShortItemComponent = cut.FindComponent<AddProfileShortItem>();
         addShortItemComponent.Find("input").Change("key");
 
@@ -126,7 +126,7 @@ public void ShouldSetNewOrderWhenItemDragAndDropped()
         ProfileInformationEntry entryToDb = null;
         repo.Setup(p => p.StoreAsync(It.IsAny<ProfileInformationEntry>()))
             .Callback<ProfileInformationEntry>(p => entryToDb = p);
-        var cut = RenderComponent<Profile>(p => p.Add(s => s.IsAuthenticated, true));
+        var cut = RenderComponent<Profile>(p => p.Add(s => s.ShowAdminActions, true));
         calculator.Setup(s => s.GetSortOrder(target, profileInformationEntries)).Returns(150);
 
         cut.FindAll("li")[1].Drag();
@@ -142,7 +142,7 @@ public void ShouldNotChangeSortOrderWhenDroppedOnItself()
         var source = new ProfileInformationEntryBuilder().WithSortOrder(200).Build();
         var (repo, _) = RegisterServices();
         SetupGetAll(repo, source);
-        var cut = RenderComponent<Profile>(p => p.Add(s => s.IsAuthenticated, true));
+        var cut = RenderComponent<Profile>(p => p.Add(s => s.ShowAdminActions, true));
 
         cut.FindAll("li")[0].Drag();
         cut.FindAll("li")[0].Drop();
diff --git a/tests/LinkDotNet.Blog.IntegrationTests/Web/Shared/Skills/SkillTableTests.cs b/tests/LinkDotNet.Blog.IntegrationTests/Web/Shared/Skills/SkillTableTests.cs
@@ -22,7 +22,7 @@ public async Task ShouldDeleteItem()
         ctx.Services.AddScoped(_ => Repository);
         ctx.Services.AddScoped(_ => Mock.Of<IToastService>());
         var cut = ctx.RenderComponent<SkillTable>(p =>
-            p.Add(s => s.IsAuthenticated, true));
+            p.Add(s => s.ShowAdminActions, true));
         cut.WaitForState(() => cut.HasComponent<SkillTag>());
 
         cut.FindComponent<SkillTag>().Find("button").Click();
@@ -39,7 +39,7 @@ public async Task ShouldAddSkill()
         ctx.Services.AddScoped(_ => Repository);
         ctx.Services.AddScoped(_ => Mock.Of<IToastService>());
         var cut = ctx.RenderComponent<SkillTable>(p =>
-            p.Add(s => s.IsAuthenticated, true));
+            p.Add(s => s.ShowAdminActions, true));
         cut.Find("button").Click();
         var dialog = cut.FindComponent<AddSkillDialog>();
         dialog.Find("#title").Change("C#");
@@ -69,10 +69,10 @@ public async Task ShouldNotAllowToEditSkillTagsWhenNotAdmin()
         ctx.Services.AddScoped(_ => Mock.Of<IToastService>());
 
         var cut = ctx.RenderComponent<SkillTable>(p =>
-            p.Add(s => s.IsAuthenticated, false));
+            p.Add(s => s.ShowAdminActions, false));
 
         cut.WaitForState(() => cut.FindComponents<SkillTag>().Any());
-        cut.FindComponent<SkillTag>().Instance.IsAuthenticated.Should().BeFalse();
+        cut.FindComponent<SkillTag>().Instance.ShowAdminActions.Should().BeFalse();
     }
 
     [Fact]
@@ -85,7 +85,7 @@ public async Task ShouldUpdateProficiencyWhenSkillTagDragged()
         ctx.Services.AddScoped(_ => Repository);
         ctx.Services.AddScoped(_ => Mock.Of<IToastService>());
         var cut = ctx.RenderComponent<SkillTable>(p =>
-            p.Add(s => s.IsAuthenticated, true));
+            p.Add(s => s.ShowAdminActions, true));
         cut.WaitForState(() => cut.FindAll(".skill-tag").Any());
 
         cut.FindAll(".skill-tag")[0].Drag();
@@ -105,7 +105,7 @@ public async Task ShouldStayOnSameProficiencyWhenDroppedOnSameProficiencyLevel()
         ctx.Services.AddScoped(_ => Repository);
         ctx.Services.AddScoped(_ => Mock.Of<IToastService>());
         var cut = ctx.RenderComponent<SkillTable>(p =>
-            p.Add(s => s.IsAuthenticated, true));
+            p.Add(s => s.ShowAdminActions, true));
         cut.WaitForState(() => cut.FindAll(".skill-tag").Any());
 
         cut.FindAll(".skill-tag")[0].Drag();
diff --git a/tests/LinkDotNet.Blog.UnitTests/Web/Features/AboutMe/AboutMePageTests.cs b/tests/LinkDotNet.Blog.UnitTests/Web/Features/AboutMe/AboutMePageTests.cs
@@ -27,8 +27,8 @@ public void ShouldPassIsAuthenticated()
 
         var cut = RenderComponent<AboutMePage>();
 
-        cut.FindComponent<Profile>().Instance.IsAuthenticated.Should().BeTrue();
-        cut.FindComponent<SkillTable>().Instance.IsAuthenticated.Should().BeTrue();
+        cut.FindComponent<Profile>().Instance.ShowAdminActions.Should().BeTrue();
+        cut.FindComponent<SkillTable>().Instance.ShowAdminActions.Should().BeTrue();
     }
 
     [Fact]
diff --git a/tests/LinkDotNet.Blog.UnitTests/Web/Features/AboutMe/Components/SkillTagTests.cs b/tests/LinkDotNet.Blog.UnitTests/Web/Features/AboutMe/Components/SkillTagTests.cs
@@ -39,7 +39,7 @@ public void ShouldInvokeDeleteEvent()
         var cut = RenderComponent<SkillTag>(p => p
             .Add(
             s => s.Skill, skill)
-            .Add(s => s.IsAuthenticated, true)
+            .Add(s => s.ShowAdminActions, true)
             .Add(s => s.DeleteSkill, () => wasInvoked = true));
 
         cut.Find("button").Click();

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`@code {`
`10`	`10`	`[Parameter]`
`11`	`11`	`public string Header { get; set; }`
	`12`	`+`
`12`	`13`	`[Parameter]`
`13`	`14`	`public RenderFragment ChildContent { get; set; }`
`14`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`ondragover="event.preventDefault();">`
`21`	`21`	`@foreach (var entry in profileInformationEntries)`
`22`	`22`	`{`
`23`		`- @if (IsAuthenticated)`
	`23`	`+ @if (ShowAdminActions)`
`24`	`24`	`{`
`25`	`25`	`<li`
`26`	`26`	`class="item-draggable"`
`@@ -39,7 +39,7 @@`
`39`	`39`	`<li>@RenderMarkupString(entry.Content)</li>`
`40`	`40`	`}`
`41`	`41`	`}`
`42`		`- @if (IsAuthenticated)`
	`42`	`+ @if (ShowAdminActions)`
`43`	`43`	`{`
`44`	`44`	`<AddProfileShortItem ValueAdded="@AddValue"></AddProfileShortItem>`
`45`	`45`	`}`
`@@ -51,7 +51,7 @@ OnYesPressed="DeleteItem"></ConfirmDialog>`
`51`	`51`
`52`	`52`	`@code {`
`53`	`53`	`[Parameter]`
`54`		`- public bool IsAuthenticated { get; set; }`
	`54`	`+ public bool ShowAdminActions { get; set; }`
`55`	`55`
`56`	`56`	`private List<ProfileInformationEntry> profileInformationEntries = new();`
`57`	`57`	`private ConfirmDialog Dialog { get; set; }`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`@using LinkDotNet.Blog.Infrastructure.Persistence`
`3`	`3`	`@inject IRepository<Skill> repository`
`4`	`4`	`<div>`
`5`		`- @if (IsAuthenticated)`
	`5`	`+ @if (ShowAdminActions)`
`6`	`6`	`{`
`7`	`7`	`<button type="button" class="btn btn-primary" @onclick="() => AddSkillDialog.Open()"><i class="fas`
`8`	`8`	`fa-plus-square"></i>`
`@@ -28,12 +28,12 @@`
`28`	`28`	`<td @ondrop="@(() => HandleDrop(skillLevel))" class="proficiency-level">`
`29`	`29`	`@foreach (var skill in skillCapabilityGroup.Where(s => s.ProficiencyLevel == skillLevel))`
`30`	`30`	`{`
`31`		`- @if (IsAuthenticated)`
	`31`	`+ @if (ShowAdminActions)`
`32`	`32`	`{`
`33`	`33`	`<div draggable="true" @ondrag="@(() => currentDragItem = skill)" style="cursor: grab"`
`34`	`34`	`class="skill-tag">`
`35`	`35`	`<SkillTag Skill="@skill"`
`36`		`- IsAuthenticated="@true"`
	`36`	`+ ShowAdminActions="@true"`
`37`	`37`	`DeleteSkill="@(() => DeleteSkill(skill))"/>`
`38`	`38`	`</div>`
`39`	`39`	`}`
`@@ -50,14 +50,14 @@`
`50`	`50`	`}`
`51`	`51`	`</tbody>`
`52`	`52`	`</table>`
`53`		`- @if (IsAuthenticated)`
	`53`	`+ @if (ShowAdminActions)`
`54`	`54`	`{`
`55`	`55`	`<small for="skill-table">You can drag and drop your skills from one proficency to another</small>`
`56`	`56`	`}`
`57`	`57`	`</div>`
`58`	`58`	`@code {`
`59`	`59`	`[Parameter]`
`60`		`- public bool IsAuthenticated { get; set; }`
	`60`	`+ public bool ShowAdminActions { get; set; }`
`61`	`61`
`62`	`62`	`private AddSkillDialog AddSkillDialog { get; set; }`
`63`	`63`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`}`
`7`	`7`	`@Skill.Name`
`8`	`8`
`9`		`- @if (IsAuthenticated)`
	`9`	`+ @if (ShowAdminActions)`
`10`	`10`	`{`
`11`	`11`	`<button type="button" class="btn btn-default" aria-label="Delete Skill" @onclick="() => DeleteSkill.InvokeAsync()">`
`12`	`12`	`<i class="fas fa-trash-alt" aria-hidden="true"></i>`
`@@ -19,7 +19,7 @@`
`19`	`19`	`public Skill Skill { get; set; }`
`20`	`20`
`21`	`21`	`[Parameter]`
`22`		`- public bool IsAuthenticated { get; set; }`
	`22`	`+ public bool ShowAdminActions { get; set; }`
`23`	`23`
`24`	`24`	`[Parameter]`
`25`	`25`	`public EventCallback DeleteSkill { get; set; }`
Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,8 @@ public void ShouldPassIsAuthenticated()`
`27`	`27`
`28`	`28`	`var cut = RenderComponent<AboutMePage>();`
`29`	`29`
`30`		`- cut.FindComponent<Profile>().Instance.IsAuthenticated.Should().BeTrue();`
`31`		`- cut.FindComponent<SkillTable>().Instance.IsAuthenticated.Should().BeTrue();`
	`30`	`+ cut.FindComponent<Profile>().Instance.ShowAdminActions.Should().BeTrue();`
	`31`	`+ cut.FindComponent<SkillTable>().Instance.ShowAdminActions.Should().BeTrue();`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`[Fact]`