Simplify logic

Author: linkdotnet

src/LinkDotNet.Blog.Web/Features/Admin/BlogPostEditor/Components/PublishedWithScheduledDateValidationAttribute.cs

@@ -8,11 +8,8 @@ public sealed class PublishedWithScheduledDateValidationAttribute : ValidationAt
 {
     protected override ValidationResult IsValid(object value, ValidationContext validationContext)
     {
-        if (validationContext.ObjectInstance is CreateNewModel { IsPublished: true, ScheduledPublishDate: { } })
-        {
-            return new ValidationResult("Cannot have a scheduled publish date when the post is already published.");
-        }
-
-        return ValidationResult.Success;
+        return validationContext.ObjectInstance is CreateNewModel { IsPublished: true, ScheduledPublishDate: { } }
+            ? new ValidationResult("Cannot have a scheduled publish date when the post is already published.")
+            : ValidationResult.Success;
     }
 }

tests/LinkDotNet.Blog.UnitTests/Web/Features/Admin/BlogPostEditor/Components/PublishedWithScheduledDateValidationAttributeTests.cs

@@ -16,7 +16,7 @@ public void GivenBlogPostIsPublishedAndHasScheduledDate_WhenValidating_ThenError
             ShortDescription = "Desc",
             Content = "Content",
             IsPublished = true,
-            ScheduledPublishDate = DateTime.Now,
+            ScheduledPublishDate = DateTime.MaxValue,
             PreviewImageUrl = "https://steven-giesel.com",
         };
         var validationContext = new ValidationContext(model);