OpenIndiana does not have <sys/audioio.h> but it still uses Sun Audio driver because uname returns "SunOS" on SDL2

[Lizzie841]

My solution was to disable audio, which of course it's not a proper solution.

[sezero]

This is possibly an SDL2 issue, not SDL3, therefore wrong milestone I guess?

[icculus]

Yeah, the sunaudio backend is completely gone in SDL3.

[icculus]

What does OpenIndiana have? The internet seems to think Open Sound System v4 (/dev/dsp), but maybe PulseAudio and such are available on top of that?

[Lizzie841]

What does OpenIndiana have? The internet seems to think Open Sound System v4 (/dev/dsp), but maybe PulseAudio and such are available on top of that?

PulseAudio is offered on the desktop install, /dev/dsp and /dev/dsp0 do exist on my system through

[icculus]

Okay, I'm assuming this is happening because SDL2 CMakeLists.txt has this...

    if(SYSV5 OR SOLARIS OR HPUX)
        set(SDL_AUDIO_DRIVER_SUNAUDIO 1)
        file(GLOB SUN_AUDIO_SOURCES ${SDL2_SOURCE_DIR}/src/audio/sun/*.c)
        list(APPEND SOURCE_FILES ${SUN_AUDIO_SOURCES})
        set(HAVE_SDL_AUDIO TRUE)

...and configure.ac has this...

          case $ARCH in
            sysv5|solaris|hpux)
                AC_DEFINE(SDL_AUDIO_DRIVER_SUNAUDIO, 1, [ ])
                SOURCES="$SOURCES $srcdir/src/audio/sun/*.c"
                SUMMARY_audio="${SUMMARY_audio} sun"
                have_audio=yes

And the "solaris" checks are passing on OpenIndiana.

What we should do is check if <sys/audioio.h> is available too, because I bet this affects other post-Solaris OSes, too.

All the existing Open Sound System and PulseAudio checks probably work as-is, but it's blowing up because it's trying to build this thing unconditionally, so my assumption is that fixing this specific thing will get you working audio generally.

[icculus]

I pushed a potential fix for this, @Lizzie841, if you could try the latest in the SDL2 branch and let me know if it works.

It should no longer try to build the old Solaris audio backend, and it (in theory) should build at least the "dsp" backend, which hopefully will get you sound, and also the "pulseaudio" backend if you have PulseAudio installed on the system.

Let me know if it doesn't work!

[sezero]

P.S.: There is some weird / evil ifdef'ery in SDL_sunaudio.c: should we
do something like the following?

diff --git a/src/audio/sun/SDL_sunaudio.c b/src/audio/sun/SDL_sunaudio.c
index b596bec..2a046c4 100644
--- a/src/audio/sun/SDL_sunaudio.c
+++ b/src/audio/sun/SDL_sunaudio.c
@@ -24,18 +24,12 @@
 
 /* Allow access to a raw mixing buffer */
 
+#include <sys/types.h>
 #include <fcntl.h>
 #include <errno.h>
-#ifdef __NETBSD__
 #include <sys/ioctl.h>
 #include <sys/audioio.h>
-#endif
-#ifdef __SVR4
-#include <sys/audioio.h>
-#else
 #include <sys/time.h>
-#include <sys/types.h>
-#endif
 #include <unistd.h>
 
 #include "SDL_timer.h"

[icculus]

@sezero Yeah, go ahead and apply that patch.

[sezero]

@sezero Yeah, go ahead and apply that patch.

Applied to SDL2 branch