Deprecate iterators returned by mdns::Event
#3612
Closed
drHuangMHT
started this conversation in
Ideas
Replies: 1 comment
-
I think this would just have to be a breaking change. Can you open a draft PR with the API you are thinking of? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Let's push #3593 and #3606 further. Since it feels wrong to clone single-use iterators, and you have to manually convert a
SmallVec
into an iterator before putting it into an event, why not get our hands on deprecating them? However, I cannot come up with a way to gently roll out the change and I guess it's not possible to do so. But adapting to the change for established code is relatively easy, you'll only need to additer()
orinto_iter()
to make things work again temporarily and re-design later.Beta Was this translation helpful? Give feedback.
All reactions