Skip to content

Commit 922d4c7

Browse files
committed
Remove redundant type check for std::vector<int> in GetNamespaceTest.
1 parent 262ab34 commit 922d4c7

File tree

1 file changed

+1
-17
lines changed

1 file changed

+1
-17
lines changed

modules/core/performance/tests/perf_tests.cpp

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
#include <gtest/gtest.h>
22

3-
#include <chrono>
43
#include <cstdint>
54
#include <filesystem>
65
#include <fstream>
76
#include <memory>
87
#include <stdexcept>
98
#include <string_view>
10-
#include <thread>
119
#include <vector>
1210

1311
#include "core/performance/include/performance.hpp"
@@ -208,18 +206,6 @@ class DummyTask : public ppc::core::Task<int, int> {
208206
bool PostProcessingImpl() override { return true; }
209207
};
210208

211-
class SlowTask : public ppc::core::Task<int, int> {
212-
public:
213-
using Task::Task;
214-
bool ValidationImpl() override { return true; }
215-
bool PreProcessingImpl() override { return true; }
216-
bool RunImpl() override { return true; }
217-
bool PostProcessingImpl() override {
218-
std::this_thread::sleep_for(std::chrono::seconds(2));
219-
return true;
220-
}
221-
};
222-
223209
TEST(TaskTest, GetDynamicTypeReturnsCorrectEnum) {
224210
DummyTask task;
225211
task.SetTypeOfTask(ppc::core::TypeOfTask::kOMP);
@@ -251,7 +237,7 @@ class Another {};
251237
template <typename T>
252238
class GetNamespaceTest : public ::testing::Test {};
253239

254-
using TestTypes = ::testing::Types<my::nested::Type, my::Another, int, std::vector<int>>;
240+
using TestTypes = ::testing::Types<my::nested::Type, my::Another, int>;
255241

256242
TYPED_TEST_SUITE(GetNamespaceTest, TestTypes);
257243

@@ -264,8 +250,6 @@ TYPED_TEST_NOLINT(GetNamespaceTest, ExtractsNamespaceCorrectly) {
264250
EXPECT_EQ(kNs, "my");
265251
} else if constexpr (std::is_same_v<TypeParam, int>) {
266252
EXPECT_EQ(kNs, "");
267-
} else if constexpr (std::is_same_v<TypeParam, std::vector<int>>) {
268-
EXPECT_EQ(kNs, "std");
269253
} else {
270254
FAIL() << "Unhandled type in test";
271255
}

0 commit comments

Comments
 (0)