Skip to content

Commit 8b7417b

Browse files
authored
[CI] Fail on sanitizer errors (#235)
1 parent c8575f4 commit 8b7417b

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

.github/workflows/main.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,31 +383,41 @@ jobs:
383383
CXX: clang++-19
384384
- name: Run tests (MPI)
385385
run: |
386-
export ASAN_RUN=1
387386
source scripts/run_mpi.sh "--oversubscribe"
388387
env:
389388
PROC_COUNT: 2
390389
OMP_NUM_THREADS: 2
390+
ASAN_RUN: 1
391+
ASAN_OPTIONS: abort_on_error=1
392+
UBSAN_OPTIONS: halt_on_error=1
391393
- name: Run tests (threads, num_threads=1)
392394
run: source scripts/run_threads.sh
393395
env:
394396
OMP_NUM_THREADS: 1
395397
ASAN_RUN: 1
398+
ASAN_OPTIONS: abort_on_error=1
399+
UBSAN_OPTIONS: halt_on_error=1
396400
- name: Run tests (threads, num_threads=2)
397401
run: source scripts/run_threads.sh
398402
env:
399403
OMP_NUM_THREADS: 2
400404
ASAN_RUN: 1
405+
ASAN_OPTIONS: abort_on_error=1
406+
UBSAN_OPTIONS: halt_on_error=1
401407
- name: Run tests (threads, num_threads=3)
402408
run: source scripts/run_threads.sh
403409
env:
404410
OMP_NUM_THREADS: 3
405411
ASAN_RUN: 1
412+
ASAN_OPTIONS: abort_on_error=1
413+
UBSAN_OPTIONS: halt_on_error=1
406414
- name: Run tests (threads, num_threads=4)
407415
run: source scripts/run_threads.sh
408416
env:
409417
OMP_NUM_THREADS: 4
410418
ASAN_RUN: 1
419+
ASAN_OPTIONS: abort_on_error=1
420+
UBSAN_OPTIONS: halt_on_error=1
411421
ubuntu-clang-sanitizer-build-extended:
412422
needs:
413423
- ubuntu-clang-sanitizer-build

cmake/sanitizers.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ if(CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER_ID MATCHES "GNU")
66
message(STATUS "Enabled address sanitizer")
77
endif()
88
if (ENABLE_UB_SANITIZER)
9-
add_compile_options(-fsanitize=undefined)
10-
add_link_options(-fsanitize=undefined)
9+
add_compile_options(-fsanitize=undefined -fno-sanitize=signed-integer-overflow)
10+
add_link_options(-fsanitize=undefined -fno-sanitize=signed-integer-overflow)
1111
message(STATUS "Enabled UB sanitizer")
1212
endif()
1313
else()

0 commit comments

Comments
 (0)