Delegate clang-tidy -Werror enforcement to CMake instead of .clang-tidy

Author: aobolensk

.clang-tidy

@@ -41,7 +41,6 @@ Checks: >
   -portability-template-virtual-member-function,
   -readability-magic-numbers
 
-WarningsAsErrors: "*"
 HeaderFilterRegex: '.*/(modules|tasks)/.*'
 
 CheckOptions:

.github/workflows/static-analysis-pr.yml

@@ -47,7 +47,7 @@ jobs:
       - name: CMake configure
         run: >
           cmake -S . -B build -G Ninja
-          -D CMAKE_BUILD_TYPE=RELEASE -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
+          -D CMAKE_BUILD_TYPE=RELEASE -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
         env:
           CC: clang-21
           CXX: clang++-21
@@ -96,7 +96,7 @@ jobs:
       - name: CMake configure
         run: >
           cmake -S . -B build -G Ninja
-          -D CMAKE_BUILD_TYPE=RELEASE -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
+          -D CMAKE_BUILD_TYPE=RELEASE -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
         env:
           CC: gcc-14
           CXX: g++-14

tasks/example_threads/tbb/src/ops_tbb.cpp

@@ -42,7 +42,7 @@ bool NesterovATestTaskTBB::RunImpl() {
   GetOutput() *= num_threads;
 
   std::atomic<int> counter(0);
-  tbb::parallel_for(0, ppc::util::GetNumThreads(), [&](int /*i*/) { counter++; });
+  tbb::parallel_for(0, ppc::util::GetNumThreads(), [&](int i) { counter++; });
 
   GetOutput() /= counter;
   return GetOutput() > 0;