shipping tax error log....

[proseLA]

getting this error:

PHP Warning: Undefined array key "shipping_tax" in /.../myAdmin/includes/classes/editOrders.php on line 324.

edit_orders/YOUR_ADMIN/includes/classes/editOrders.php

Line 324 in 769b2cc

$this->shipping_tax_rate = is_numeric($_POST['shipping_tax']) ? $_POST['shipping_tax'] : 0;

this code seems to resolve it:

$this->shipping_tax_rate = empty($_POST['shipping_tax']) ? 0 : (is_numeric($_POST['shipping_tax']) ? $_POST['shipping_tax'] : 0);

[lat9]

What Zen Cart version?

[proseLA]

v2.0.0

[lat9]

I'm trying to understand why that posted variable wasn't present, noting that the 'shipping_tax' input variable is included by the form:

edit_orders/YOUR_ADMIN/includes/modules/edit_orders/eo_edit_action_ot_table_display.php

Lines 100 to 119 in 769b2cc

	case 'ot_shipping':
	$shipping_tax_rate = $eo->eoGetShippingTaxRate($order);
	$shipping_title_max = 'maxlength="' . zen_field_length(TABLE_ORDERS, 'shipping_method') . '"';
	?>
	<td class="a-r"><?php echo zen_draw_hidden_field($update_total_code, $total['class']) . zen_draw_pull_down_menu($update_total . '[shipping_module]', eo_get_available_shipping_modules(), $order->info['shipping_module_code']) . '&nbsp;&nbsp;' . zen_draw_input_field($update_total_title, $trimmed_title, 'class="amount eo-entry" ' . $shipping_title_max); ?></td>
	<td class="a-r"><?php echo zen_draw_input_field('shipping_tax', (string)$shipping_tax_rate, 'class="amount" id="s-t"' . $input_tax_parms, false, $input_field_type); ?>&nbsp;%</td>
	<?php
	if (DISPLAY_PRICE_WITH_TAX === 'true') {
	$shipping_net = $details['value'] / (1 + ($shipping_tax_rate / 100));
	?>
	<td class="a-r"><?php echo zen_draw_input_field($update_total_value, (string)$shipping_net, 'class="amount" id="s-n"' . $input_value_parms, false, $input_field_type); ?></td>
	<?php
	$update_total_value = 'shipping_gross';
	}
	?>
	<td>&nbsp;</td>
	<td class="smallText a-r"><?php echo zen_draw_input_field($update_total_value, $details['value'], 'class="amount" id="s-g"' . $input_value_parms, false, $input_field_type); ?></td>
	<?php
	break;

Does the order, for some obscure reason, not have an 'ot_shipping' component?

[proseLA]

Does the order, for some obscure reason, not have an 'ot_shipping' component?

last time i checked, ot_shipping is a configurable option.

and even if it is an obscure reason, why should edit orders not take the lack of a ot_shipping component into account?

[lat9]

You're right, it should be a consideration; it's just very unusual.