validateInteger incorrectly passes bool true

[jlt-jacksondawson]

Laravel Version

current 12.x

PHP Version

all

Database Driver & Version

No response

Description

I found #28685 which was closed, attributing the problem to a PHP "bug."

Per PHP's documentation of filter_var():

Because true is being converted to "1", it then passes as an int-ish value.

This isn't technically a PHP bug. it's a type coercion quirk/gotcha that should be accounted for.

The workaround suggested in the other issue should be the permanent fix:

return is_numeric($value) && filter_var($value, FILTER_VALIDATE_INT);

Steps To Reproduce

Pass Boolean true to a field validation with the integer rule set.

[Rizky92]

This is already clarified in the docs. I don't think it's an issue, but something to be accounted for when validating integers.

[jlt-jacksondawson]

I find it confusing and misleading to call the validation "integer" but not promise it detects an actual integer (or integer string). "Integer" implies "numeric" so it doesn't make sense to require both to get a real validation. It's an unnecessary gotcha that shouldn't require a documentation warning to avoid the trap.

The required change is minuscule and obvious: add is_numeric() to the condition, baking the numeric validation into it.

To provide lower validation overhead, and clearer intent + results, I think it's worth changing.

[crynobone]

Feel free to suggest a PR for Taylor to review. At the moment docs already explained the limitation and changing the behaviour now may cause breaking changes to existing application.