Inconsistent config name for queue baching

[naciriii]

I was working on a feature that includes batch of jobs on a multi tenant software where all jobs are dispatched on landlord connection/db.

I was blindly trying to set batching connection for my batch through 'connection' param under batching in config/queue.php , however it was still using tenant connection and failing to add the jobs ..

After debugging through internals of laravel , I noticed the param name was actually 'database' which is used to set connection to use for batches which I found a bit inconsistent and misleading compared to the rest of similar config.

Note

Same appllies for failed_jobs config as well

// lluminate\Bus\BusServiceProvider
 $this->app->singleton(DatabaseBatchRepository::class, function ($app) {
            return new DatabaseBatchRepository(
                $app->make(BatchFactory::class),
                $app->make('db')->connection($app->config->get('queue.batching.database')),
                $app->config->get('queue.batching.table', 'job_batches')
            );
        });

My suggestion is to rename the config param to connection for both batching and job_failed in config/queue.php instead of misleading database