You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I needed a small feature - logging with a token prefixed to my message (depending on the specified logger) - I found that the best way would be to define a 'tap' option, and I wanted it with a generic class that would modify the format of the message with a passed argument, but I observed that (a) it's not documented anywhere how you should pass arguments and (b) it's pretty ugly to give arguments since they can only be passed as a string, not as an array, and this comes with some limitations. The idea would be to allow to specify tap like this:
I already made my way through the code to make this small change and I could make a pull request, but is this worth pursuing / the right way to contribute?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hello,
I needed a small feature - logging with a token prefixed to my message (depending on the specified logger) - I found that the best way would be to define a 'tap' option, and I wanted it with a generic class that would modify the format of the message with a passed argument, but I observed that (a) it's not documented anywhere how you should pass arguments and (b) it's pretty ugly to give arguments since they can only be passed as a string, not as an array, and this comes with some limitations. The idea would be to allow to specify tap like this:
I already made my way through the code to make this small change and I could make a pull request, but is this worth pursuing / the right way to contribute?
Thank you!
Beta Was this translation helpful? Give feedback.
All reactions