Skip to content

chore: remove the jump out icon of account #20475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: remove the jump out icon of account #20475

wants to merge 1 commit into from

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented May 30, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #20474

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 30, 2025
@DavideDelbianco
Copy link
Contributor

If you remove the icon from the Account option, then maybe you should remove also the icon from the action that brings you back:
image

@crazywoola
Copy link
Member

From our designer: It should open in a new tab instead of removing the icon.

@DavideDelbianco
Copy link
Contributor

Target blank to account -> target blank to studio.
Now you have 3 tabs to manage something that could have been inside a modal like the settings

@crazywoola crazywoola closed this Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove the jump out icon of account
3 participants
@hjlarry @DavideDelbianco @crazywoola