Skip to content

Refactor API responsiveness tests which use klog #1286

Open
@tosi3k

Description

@tosi3k

Current implementation of logging tests relies too much on turning off logging to stderr by klog which is possible to be done using a hack as below:

klog.InitFlags(nil)
flag.Set("logtostderr", "false")
flag.Parse()

Idea: introduce some Logger interface which will be easy to mock and will facilitate catching the log statements inside the unit tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions