Add addon registry build integration test

[spowelljr]

Currently, the addon registry integration test tests against the Kubernetes client.
https://github.com/kubernetes/minikube/blob/master/test/integration/addons_test.go#L224

We should add a new test where we actually build and push the image to the registry.

To check if the image is pushed to the registry use the following command:

% curl -X GET http://$(minikube ip):5000/v2/_catalog 
{"repositories":["test-img"]}

[anencore94]

Hi @spowelljr !, If you don't mind, would I take this issue ?

And I guess you mean the Line #L224 not #L140, right?

minikube/test/integration/addons_test.go

Line 224 in ff0e25a

func validateRegistryAddon(ctx context.Context, t *testing.T, profile string) {

Also, I think testing docker push and docker pull the image to the registry is fine, building the new image on test time is not what we want to test actually. I think we could use pre-built docker image with .tar or just pull from docker hub and then push it to our addon-registry

By the way, If I make the test, I wonder do we have to push image in some pod or not(just in the host). I think it is just fine to test push in the host machine(=minikube), if it has docker cli binary or some other requirements I missed.

[medyagh]

@anencore94 go for it !

[spowelljr]

@anencore94 Yes, I did mean line 224 and not 140, that was my mistake.

[anencore94]

/assign

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale