Skip to content

Commit 4acd3fe

Browse files
pohlyk8s-publishing-bot
authored andcommitted
remove import doc comments
The "// import <path>" comment has been superseded by Go modules. We don't have to remove them, but doing so has some advantages: - They are used inconsistently, which is confusing. - We can then also remove the (currently broken) hack/update-vanity-imports.sh. - Last but not least, it would be a first step towards avoiding the k8s.io domain. This commit was generated with sed -i -e 's;^package \(.*\) // import.*;package \1;' $(git grep -l '^package.*// import' | grep -v 'vendor/') Everything was included, except for package labels // import k8s.io/kubernetes/pkg/util/labels because that package is marked as "read-only". Kubernetes-commit: 8a908e0c0bd96a3455edf7e3b5f5af90564e65b0
1 parent cc88ac2 commit 4acd3fe

File tree

21 files changed

+21
-21
lines changed

21 files changed

+21
-21
lines changed

cmd/defaulter-gen/output_tests/empty/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ limitations under the License.
1717
// +k8s:defaulter-gen=covers
1818

1919
// This is a test package.
20-
package empty // import "k8s.io/code-generator/cmd/defaulter-gen/output_tests/empty"
20+
package empty

cmd/defaulter-gen/output_tests/marker/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ limitations under the License.
1717
// +k8s:defaulter-gen=TypeMeta
1818

1919
// This is a test package.
20-
package marker // import "k8s.io/code-generator/cmd/defaulter-gen/output_tests/marker"
20+
package marker

cmd/defaulter-gen/output_tests/pointer/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ limitations under the License.
1717
// +k8s:defaulter-gen=TypeMeta
1818

1919
// This is a test package.
20-
package pointer // import "k8s.io/code-generator/cmd/defaulter-gen/output_tests/pointer"
20+
package pointer

cmd/defaulter-gen/output_tests/slices/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ limitations under the License.
1717
// +k8s:defaulter-gen=TypeMeta
1818

1919
// This is a test package.
20-
package slices // import "k8s.io/code-generator/cmd/defaulter-gen/output_tests/slices"
20+
package slices

cmd/defaulter-gen/output_tests/wholepkg/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ limitations under the License.
1717
// +k8s:defaulter-gen=TypeMeta
1818

1919
// This is a test package.
20-
package wholepkg // import "k8s.io/code-generator/cmd/defaulter-gen/output_tests/wholepkg"
20+
package wholepkg

doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ See the License for the specific language governing permissions and
1414
limitations under the License.
1515
*/
1616

17-
package codegenerator // import "k8s.io/code-generator"
17+
package codegenerator

examples/HyphenGroup/apis/example/v1/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ limitations under the License.
1818
// +k8s:defaulter-gen=TypeMeta
1919
// +groupName=example-group.hyphens.code-generator.k8s.io
2020
// +groupGoName=ExampleGroup
21-
package v1 // import "k8s.io/code-generator/examples/HyphenGroup/apis/example/v1"
21+
package v1

examples/MixedCase/apis/example/v1/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ limitations under the License.
1717
// +k8s:deepcopy-gen=package
1818
// +k8s:defaulter-gen=TypeMeta
1919
// +groupName=example.crd.code-generator.k8s.io
20-
package v1 // import "k8s.io/code-generator/examples/MixedCase/apis/example/v1"
20+
package v1

examples/apiserver/apis/core/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ limitations under the License.
1717
// +k8s:deepcopy-gen=package
1818
// +groupName=
1919

20-
package core // import "k8s.io/code-generator/examples/apiserver/apis/core"
20+
package core

examples/apiserver/apis/core/v1/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ limitations under the License.
2020
// +k8s:conversion-gen=k8s.io/code-generator/examples/apiserver/apis/core
2121
// +groupName=
2222

23-
package v1 // import "k8s.io/code-generator/examples/apiserver/apis/core/v1"
23+
package v1

0 commit comments

Comments
 (0)