Migrate JobSet from Kubebuilder v3 to v4

[GiuseppeTT]

What would you like to be done: Migrate JobSet from Kubebuilder v3 to v4

I noticed that the JobSet repository uses Kubebuilder v3, whereas the latest version is v4. Also, it seems that JobSet follows older conventions from Kubebuilder like having the main file at the root instead of in cmd/

Why is this needed: Improve compatibility with Kubebuilder, which is a standard tool for building controllers. This should help with any project changes like upgrading JobSet to v1

cc @kannon92 @andreyvelich @tenzen-y @ahg-g @imreddy13

[kannon92]

/kind cleanup

[tchap]

I guess the approach would be to simply generate a whole new project and put existing code in there?

[tenzen-y]

IIUC, we use kubebuilder only when we initialize this repository. So, I guess that we could remove the kubebuilder-related contents.

[kannon92]

Hmm, those are some good points.

I was thinking we would mainly change the suggestions from to v4.

@GiuseppeTT what is your plan for addressing this?

[GiuseppeTT]

I was thinking we would mainly change the suggestions from to v4.

Do you mean manually changing this line?

@GiuseppeTT what is your plan for addressing this?

Honestly, I don't have plan 😅 . The kubebuilder book doesn't have a nice migration tutorial from v3 to v4 like it does for v2 to v3 https://book.kubebuilder.io/migrations. We could follow @tchap's suggestion (create a new folder using kubebuilder v4, move the JobSet files to there and create a PR out of it) but it seems more work than it's worth.