Skip to content

Commit a46405c

Browse files
change SupportedFeatures API to a list of subobjects (#3200)
1 parent c94d401 commit a46405c

File tree

8 files changed

+141
-28
lines changed

8 files changed

+141
-28
lines changed

apis/applyconfiguration/apis/v1/gatewayclassstatus.go

Lines changed: 7 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/applyconfiguration/apis/v1/supportedfeature.go

Lines changed: 43 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/applyconfiguration/internal/internal.go

Lines changed: 10 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/applyconfiguration/utils.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1/gatewayclass_types.go

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -261,9 +261,10 @@ type GatewayClassStatus struct {
261261
Conditions []metav1.Condition `json:"conditions,omitempty"`
262262

263263
// SupportedFeatures is the set of features the GatewayClass support.
264-
// It MUST be sorted in ascending alphabetical order.
264+
// It MUST be sorted in ascending alphabetical order by the Name key.
265265
// +optional
266-
// +listType=set
266+
// +listType=map
267+
// +listMapKey=name
267268
// <gateway:experimental>
268269
// +kubebuilder:validation:MaxItems=64
269270
SupportedFeatures []SupportedFeature `json:"supportedFeatures,omitempty"`
@@ -278,6 +279,10 @@ type GatewayClassList struct {
278279
Items []GatewayClass `json:"items"`
279280
}
280281

281-
// SupportedFeature is used to describe distinct features that are covered by
282+
// FeatureName is used to describe distinct features that are covered by
282283
// conformance tests.
283-
type SupportedFeature string
284+
type FeatureName string
285+
286+
type SupportedFeature struct {
287+
Name FeatureName `json:"name"`
288+
}

apis/v1/zz_generated.deepcopy.go

Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/experimental/gateway.networking.k8s.io_gatewayclasses.yaml

Lines changed: 26 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/generated/openapi/zz_generated.openapi.go

Lines changed: 29 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)