How to surfacing runtime hook blocking cluster deletion in condition

[ykakarap]

Details:

This issue is to discuss how to surface that a cluster deletion is blocked when the BeforeClusterDelete hook blocks the deletion of a process with a blocking response.

We have 2 options:

1. Use TopologyReconciled condition - Since only managed clusters are affected by BeforeClusterDelete hook we can use the TopologyReconciled condition to surface if a cluster deletion is blocked. Reason will be LifecycleHookBlocking. This will be consistent with how the other lifecycle hook blocking cases are surfaced.

2. Use a separate condition - Since TopologyReconciled condition reflects if the underlying objects reflect the topology spec of the cluster using it for delete might be deviating from it purpose.

Some additional concerns:

• How should the condition be updated after deletion is unblocked and the cluster is in the process of deleting the objects?
• Which controller owns this condition?

/area runtime-sdk

[k8s-ci-robot]

@ykakarap: The label(s) kind/runtime-sdk cannot be applied, because the repository doesn't have them.

In response to this:

Details:

This issue is to discuss how to surface that a cluster deletion is blocked when the BeforeClusterDelete hook blocks the deletion of a process with a blocking response.

We have 2 options:

1. Use TopologyReconciled condition - Since only managed clusters are affected by BeforeClusterDelete hook we can use the TopologyReconciled condition to surface if a cluster deletion is blocked. Reason will be LifecycleHookBlocking. This will be consistent with how the other lifecycle hook blocking cases are surfaced.

2. Use a separate condition - Since TopologyReconciled condition reflects if the underlying objects reflect the topology spec of the cluster using it for delete might be deviating from it purpose.

Some additional concerns:

• How should the condition be updated after deletion is unblocked and the cluster is in the process of deleting the objects?
• Which controller owns this condition?

/kind runtime-sdk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ykakarap]

/area runtime-sdk

[ykakarap]

/cc @fabriziopandini @sbueringer

[sbueringer]

I think we should also discuss how we surface the various "blocking states" of reconcileDelete of the regular controller (deleting MDs/ControlPlane/InfraCluster/ ...) so that all our "delete" condition(s) fit nicely together

I'm not sure if we need an owner for a condition. If the condition is written by different controllers at different times I wonder if that's good enough (topology controller until the BeforeClusterDelete hook is successfully called, cluster controller afterwards).

One comment, considering that reconcileDelete of the regular controller is deleting MD/ControlPlane/InfraCluster this is essentially "delete" reconciliation of the objects of the managed topology. Even if we implemented that before ClusterClass and it works with non-classy clusters as well.

[fabriziopandini]

/triage accepted

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[fabriziopandini]

/lifecycle frozen

[k8s-triage-robot]

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

• Confirm that this issue is still relevant with /triage accepted (org members only)
• Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted