Skip to content

Improve test coverage of Machine controller reconcileDelete #11626

Open
@sbueringer

Description

@sbueringer

While adding sorting for hooks in condition messages it came up that we don't have test coverage for this part of the code: #11624 (comment)

The code we changed was adding sorting for hooks via these two PRs:

But the entire code for the pre-terminate and pre-drain hooks in reconcileDelete has no test coverage

Metadata

Metadata

Assignees

Labels

area/machineIssues or PRs related to machine lifecycle managementarea/testingIssues or PRs related to testingkind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions