Merge pull request #5403 from jayesh-srivastava/branch-02

🌱Added comments to `WatchFilterValue` in all the Reconcilers types.

Author: k8s-ci-robot

bootstrap/kubeadm/controllers/kubeadmconfig_controller.go

@@ -71,8 +71,10 @@ type InitLocker interface {
 
 // KubeadmConfigReconciler reconciles a KubeadmConfig object.
 type KubeadmConfigReconciler struct {
-	Client           client.Client
-	KubeadmInitLock  InitLocker
+	Client          client.Client
+	KubeadmInitLock InitLocker
+
+	// WatchFilterValue is the label value used to filter events prior to reconciliation.
 	WatchFilterValue string
 
 	remoteClientGetter remote.ClusterClientGetter

controllers/cluster_controller.go

@@ -64,7 +64,9 @@ const (
 
 // ClusterReconciler reconciles a Cluster object.
 type ClusterReconciler struct {
-	Client           client.Client
+	Client client.Client
+
+	// WatchFilterValue is the label value used to filter events prior to reconciliation.
 	WatchFilterValue string
 
 	recorder        record.EventRecorder

controllers/machine_controller.go

@@ -75,8 +75,10 @@ var (
 
 // MachineReconciler reconciles a Machine object.
 type MachineReconciler struct {
-	Client           client.Client
-	Tracker          *remote.ClusterCacheTracker
+	Client  client.Client
+	Tracker *remote.ClusterCacheTracker
+
+	// WatchFilterValue is the label value used to filter events prior to reconciliation.
 	WatchFilterValue string
 
 	controller      controller.Controller

controllers/machinedeployment_controller.go

@@ -53,7 +53,9 @@ var (
 
 // MachineDeploymentReconciler reconciles a MachineDeployment object.
 type MachineDeploymentReconciler struct {
-	Client           client.Client
+	Client client.Client
+
+	// WatchFilterValue is the label value used to filter events prior to reconciliation.
 	WatchFilterValue string
 
 	recorder record.EventRecorder

controllers/machinehealthcheck_controller.go

@@ -72,8 +72,10 @@ const (
 
 // MachineHealthCheckReconciler reconciles a MachineHealthCheck object.
 type MachineHealthCheckReconciler struct {
-	Client           client.Client
-	Tracker          *remote.ClusterCacheTracker
+	Client  client.Client
+	Tracker *remote.ClusterCacheTracker
+
+	// WatchFilterValue is the label value used to filter events prior to reconciliation.
 	WatchFilterValue string
 
 	controller controller.Controller

controllers/machineset_controller.go

@@ -67,8 +67,10 @@ var (
 
 // MachineSetReconciler reconciles a MachineSet object.
 type MachineSetReconciler struct {
-	Client           client.Client
-	Tracker          *remote.ClusterCacheTracker
+	Client  client.Client
+	Tracker *remote.ClusterCacheTracker
+
+	// WatchFilterValue is the label value used to filter events prior to reconciliation.
 	WatchFilterValue string
 
 	recorder record.EventRecorder

controllers/remote/cluster_cache_reconciler.go

@@ -33,9 +33,11 @@ import (
 // ClusterCacheReconciler is responsible for stopping remote cluster caches when
 // the cluster for the remote cache is being deleted.
 type ClusterCacheReconciler struct {
-	Log              logr.Logger
-	Client           client.Client
-	Tracker          *ClusterCacheTracker
+	Log     logr.Logger
+	Client  client.Client
+	Tracker *ClusterCacheTracker
+
+	// WatchFilterValue is the label value used to filter events prior to reconciliation.
 	WatchFilterValue string
 }
 

controllers/topology/cluster_controller.go

@@ -48,7 +48,9 @@ type ClusterReconciler struct {
 	Client client.Client
 	// APIReader is used to list MachineSets directly via the API server to avoid
 	// race conditions caused by an outdated cache.
-	APIReader        client.Reader
+	APIReader client.Reader
+
+	// WatchFilterValue is the label value used to filter events prior to reconciliation.
 	WatchFilterValue string
 
 	// UnstructuredCachingClient provides a client that forces caching of unstructured objects,

controlplane/kubeadm/controllers/controller.go

@@ -61,10 +61,12 @@ import (
 
 // KubeadmControlPlaneReconciler reconciles a KubeadmControlPlane object.
 type KubeadmControlPlaneReconciler struct {
-	Client           client.Client
-	controller       controller.Controller
-	recorder         record.EventRecorder
-	Tracker          *remote.ClusterCacheTracker
+	Client     client.Client
+	controller controller.Controller
+	recorder   record.EventRecorder
+	Tracker    *remote.ClusterCacheTracker
+
+	// WatchFilterValue is the label value used to filter events prior to reconciliation.
 	WatchFilterValue string
 
 	managementCluster         internal.ManagementCluster

exp/addons/controllers/clusterresourceset_controller.go

@@ -61,8 +61,10 @@ var (
 
 // ClusterResourceSetReconciler reconciles a ClusterResourceSet object.
 type ClusterResourceSetReconciler struct {
-	Client           client.Client
-	Tracker          *remote.ClusterCacheTracker
+	Client  client.Client
+	Tracker *remote.ClusterCacheTracker
+
+	// WatchFilterValue is the label value used to filter events prior to reconciliation.
 	WatchFilterValue string
 }