Skip to content

Commit a261193

Browse files
committed
Propagate the deletion related timeout from MD to old MS when old MS is getting deleted
Signed-off-by: Lubron Zhan <[email protected]>
1 parent ef10e5a commit a261193

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,10 @@ func (r *Reconciler) reconcileOldMachineSetsOnDelete(ctx context.Context, oldMSs
109109
log.V(4).Info("Failed to convert MachineSet label selector to a map", "err", err)
110110
continue
111111
}
112+
log.V(4).Info("Ensure old MachineSet has deletion related timeouts propagated from MachineDeployment")
113+
oldMS.Spec.Template.Spec.NodeDrainTimeout = deployment.Spec.Template.Spec.NodeDrainTimeout
114+
oldMS.Spec.Template.Spec.NodeDeletionTimeout = deployment.Spec.Template.Spec.NodeDeletionTimeout
115+
oldMS.Spec.Template.Spec.NodeVolumeDetachTimeout = deployment.Spec.Template.Spec.NodeVolumeDetachTimeout
112116
log.V(4).Info("Fetching Machines associated with MachineSet")
113117
// Get all Machines linked to this MachineSet.
114118
allMachinesInOldMS := &clusterv1.MachineList{}

0 commit comments

Comments
 (0)