KubeadmControlPlane status.updated should be calculated appropriately

This change makes sure that the UpToDateMachines method always returns
a filter based on real data. Instead of looking at
(Machines - MachinesThatNeedRollout), which excludes all machines being
deleted as well, looks at all machines that match the expected
configuration and aren't scheduled for a rollout.

Signed-off-by: Vince Prignano <[email protected]>

Author: vincepri

controlplane/kubeadm/internal/control_plane.go

@@ -270,7 +270,12 @@ func (c *ControlPlane) MachinesNeedingRollout() collections.Machines {
 // UpToDateMachines returns the machines that are up to date with the control
 // plane's configuration and therefore do not require rollout.
 func (c *ControlPlane) UpToDateMachines() collections.Machines {
-	return c.Machines.Difference(c.MachinesNeedingRollout())
+	return c.Machines.Filter(
+		// Machines that shouldn't be rolled out after the deadline has expired.
+		collections.Not(collections.ShouldRolloutAfter(&c.reconciliationTime, c.KCP.Spec.RolloutAfter)),
+		// Machines that match with KCP config.
+		MatchesMachineSpec(c.infraResources, c.kubeadmConfigs, c.KCP),
+	)
 }
 
 // getInfraResources fetches the external infrastructure resource for each machine in the collection and returns a map of machine.Name -> infraResource.