-
Notifications
You must be signed in to change notification settings - Fork 216
Closed as not planned
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Description
/kind bug
What steps did you take and what happened:
As noted in this issue #1187 here, the Network
field is a required field implicitly, as during the reconcile process of GCPManagedCluster, requires the presence of this field.
What we could potentially do here based on this discussion #1259 (comment) is to make it a required field either in v1beta1
or v1beta2
What did you expect to happen:
GCPManagedCluster.Network
becomes a required field.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
reference PR which fixes the controller crashing. #1259
Environment:
- Cluster-api version:
- Minikube/KIND version:
- Kubernetes version: (use
kubectl version
): - OS (e.g. from
/etc/os-release
):
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.