fix: add IgnoreUnexported to Node Taints comparison

afarbos · afarbos · commit 08175144947d · 2024-11-18T09:38:24.000-08:00
diff --git a/cloud/services/container/nodepools/reconcile.go b/cloud/services/container/nodepools/reconcile.go
@@ -370,7 +370,7 @@ func (s *Service) checkDiffAndPrepareUpdateConfig(existingNodePool *containerpb.
 		}
 	}
 	// Kubernetes taints
-	if !cmp.Equal(desiredNodePool.GetConfig().GetTaints(), existingNodePool.GetConfig().GetTaints()) {
+	if !cmp.Equal(desiredNodePool.GetConfig().GetTaints(), existingNodePool.GetConfig().GetTaints(), cmpopts.IgnoreUnexported(containerpb.NodeTaint{})) {
 		needUpdate = true
 		updateNodePoolRequest.Taints = &containerpb.NodeTaints{
 			Taints: desiredNodePool.GetConfig().GetTaints(),

Original file line number	Diff line number	Diff line change
`@@ -370,7 +370,7 @@ func (s Service) checkDiffAndPrepareUpdateConfig(existingNodePool containerpb.`
`370`	`370`	`}`
`371`	`371`	`}`
`372`	`372`	`// Kubernetes taints`
`373`		`- if !cmp.Equal(desiredNodePool.GetConfig().GetTaints(), existingNodePool.GetConfig().GetTaints()) {`
	`373`	`+ if !cmp.Equal(desiredNodePool.GetConfig().GetTaints(), existingNodePool.GetConfig().GetTaints(), cmpopts.IgnoreUnexported(containerpb.NodeTaint{})) {`
`374`	`374`	`needUpdate = true`
`375`	`375`	`updateNodePoolRequest.Taints = &containerpb.NodeTaints{`
`376`	`376`	`Taints: desiredNodePool.GetConfig().GetTaints(),`