Skip to content

Commit 7d3bc72

Browse files
authored
Merge pull request #833 from kahirokunn/cleanup/remove-cert-manager-enabled-param
🌱 Remove deprecated cert-manager.enabled parameter references
2 parents 95adca5 + 3e1786a commit 7d3bc72

File tree

2 files changed

+8
-13
lines changed

2 files changed

+8
-13
lines changed

docs/quickstart.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,13 @@ The `--wait` flag is REQUIRED for the helm install command to work. If the --wai
5252
</aside>
5353

5454
```bash
55-
helm install capi-operator capi-operator/cluster-api-operator --create-namespace -n capi-operator-system --set infrastructure.docker.enabled=true --set cert-manager.enabled=true --set configSecret.name=${CREDENTIALS_SECRET_NAME} --set configSecret.namespace=${CREDENTIALS_SECRET_NAMESPACE} --wait --timeout 90s
55+
helm install capi-operator capi-operator/cluster-api-operator --create-namespace -n capi-operator-system --set infrastructure.docker.enabled=true --set configSecret.name=${CREDENTIALS_SECRET_NAME} --set configSecret.namespace=${CREDENTIALS_SECRET_NAMESPACE} --wait --timeout 90s
5656
```
5757

5858
Docker provider can be replaced by any provider supported by [clusterctl](https://cluster-api.sigs.k8s.io/reference/providers.html#infrastructure).
5959

6060
Other options for installing Cluster API Operator are described in [full documentation](https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/docs/README.md#installation).
61-
61+
6262
# Example API Usage
6363

6464
Deploy latest version of core Cluster API components:
@@ -69,7 +69,6 @@ kind: CoreProvider
6969
metadata:
7070
name: cluster-api
7171
namespace: capi-system
72-
7372
```
7473
7574
Deploy Cluster API AWS provider with specific version, custom manager options and flags:

test/e2e/helm_test.go

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -355,8 +355,6 @@ var _ = Describe("Create a proper set of manifests when using helm charts", func
355355
"ipam.in-cluster.enabled": "true",
356356
"addon.helm.enabled": "true",
357357
"image.manager.tag": "v0.9.1",
358-
"cert-manager.enabled": "false",
359-
"cert-manager.installCRDs": "false",
360358
"core.cluster-api.version": "v1.6.2",
361359
"manager.featureGates.core.ClusterTopology": "true",
362360
"manager.featureGates.core.MachinePool": "true",
@@ -373,14 +371,12 @@ var _ = Describe("Create a proper set of manifests when using helm charts", func
373371
})
374372
It("should deploy all providers with manager defined but no feature gates enabled", func() {
375373
manifests, err := helmChart.Run(map[string]string{
376-
"configSecret.name": "test-secret-name",
377-
"configSecret.namespace": "test-secret-namespace",
378-
"core.cluster-api.enabled": "true",
379-
"infrastructure.azure.enabled": "true",
380-
"ipam.in-cluster.enabled": "true",
381-
"addon.helm.enabled": "true",
382-
"manager.cert-manager.enabled": "false",
383-
"manager.cert-manager.installCRDs": "false",
374+
"configSecret.name": "test-secret-name",
375+
"configSecret.namespace": "test-secret-namespace",
376+
"core.cluster-api.enabled": "true",
377+
"infrastructure.azure.enabled": "true",
378+
"ipam.in-cluster.enabled": "true",
379+
"addon.helm.enabled": "true",
384380
})
385381
Expect(err).ToNot(HaveOccurred())
386382
Expect(manifests).ToNot(BeEmpty())

0 commit comments

Comments
 (0)