-
Notifications
You must be signed in to change notification settings - Fork 361
Open
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Description
What happened:
The unit test "TestNodeTopology/add-csi-node" flakes a bit. See https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-csi_external-provisioner/1373/pull-kubernetes-csi-external-provisioner-unit/1920740602429837312 for report from our CI.
--- FAIL: TestNodeTopology (60.26s)
--- FAIL: TestNodeTopology/add-csi-node (60.00s)
nodes_test.go:551: unexpected error: get informers in sync: timed out waiting for the condition
How to reproduce it:
I reproduced it in v5.2.0:
$ # install `stress` tool
$ go install golang.org/x/tools/cmd/stress@latest
$ # Compile the unit tests
$ git checkout v5.2.0
$ cd pkg/capacity/topology
$ go test -c -race
$ stress -p 40 ./topology.test
(Where 40 is ~ 2x nr. of my CPUs to generate some load, the tests sleep a lot)
After few minutes:
3m10s: 6308 runs so far, 10 failures (0.16%), 40 active
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.